Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1621453004:
Use nextafter instead of nexttoward to avoid using long double calculation. (Closed)
DescriptionUse nextafter instead of nexttoward to avoid using long double calculation.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1621453004
Committed: https://skia.googlesource.com/skia/+/0d2bc849f9ceea1cf4fded7999e7cddb2c3b7fc4
Patch Set 1 #Patch Set 2 : Switch to nextafterf to support arm. #
Total comments: 2
Patch Set 3 : Add note back. #Messages
Total messages: 24 (10 generated)
Description was changed from ========== Use nextafter instead of nexttoward to avoid using long double calculation. BUG=skia: ========== to ========== Use nextafter instead of nexttoward to avoid using long double calculation. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
The CQ bit was checked by herb@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1621453004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1621453004/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm...)
Switch to nextafterf to support arm.
The CQ bit was checked by herb@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1621453004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1621453004/20001
herb@google.com changed reviewers: + mtklein@google.com
Adding landell because he basically has the same CL, but does not include my previous CL that changes the routine.
https://codereview.chromium.org/1621453004/diff/20001/src/core/SkScaleToSides.h File src/core/SkScaleToSides.h (left): https://codereview.chromium.org/1621453004/diff/20001/src/core/SkScaleToSides... src/core/SkScaleToSides.h:48: // Note: nexttowardf is a c99 call and should be std::nexttoward, but this is not The same note does still apply to nextafterf vs. std::nextafter.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Add note back.
https://codereview.chromium.org/1621453004/diff/20001/src/core/SkScaleToSides.h File src/core/SkScaleToSides.h (left): https://codereview.chromium.org/1621453004/diff/20001/src/core/SkScaleToSides... src/core/SkScaleToSides.h:48: // Note: nexttowardf is a c99 call and should be std::nexttoward, but this is not On 2016/01/22 17:44:32, mtklein wrote: > The same note does still apply to nextafterf vs. std::nextafter. Done.
The CQ bit was checked by herb@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1621453004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1621453004/40001
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by herb@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1621453004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1621453004/40001
Message was sent while issue was closed.
Description was changed from ========== Use nextafter instead of nexttoward to avoid using long double calculation. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Use nextafter instead of nexttoward to avoid using long double calculation. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/0d2bc849f9ceea1cf4fded7999e7cddb2c3b7fc4 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://skia.googlesource.com/skia/+/0d2bc849f9ceea1cf4fded7999e7cddb2c3b7fc4 |
