Issue 1621433002: Precompilation: Class::SetFunctions can shrink the number of functions, remember to clear the hash …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1621433002: Precompilation: Class::SetFunctions can shrink the number of functions, remember to clear the hash … (Closed)

Created:
4 years, 11 months ago by rmacnak

Modified:
4 years, 11 months ago

Reviewers:
hausner

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Precompilation: Class::SetFunctions can shrink the number of functions, remember to clear the hash table if it isn't needed anymore. precompiled dart2js x64 23054428 -> 22598925 (-1.97%) R=hausner@google.com Committed: https://github.com/dart-lang/sdk/commit/f3b364ec9aba41cba2c558595bc3db9f5351e9b8

Created: 4 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	runtime/vm/object.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Total messages: 5 (2 generated)

rmacnak

4 years, 11 months ago (2016-01-21 22:58:07 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
f3b364ec9aba41cba2c558595bc3db9f5351e9b8 (presubmit successful).