Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1621313002: Track stats for errors in AUAudioInputStream. (Closed)

Created:
4 years, 11 months ago by tommi (sloooow) - chröme
Modified:
4 years, 11 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Track stats for errors in AUAudioInputStream. BUG=549021 Committed: https://crrev.com/657a3f6b3e816c7293093dd0b799453dcb947c9b Cr-Commit-Position: refs/heads/master@{#371351}

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M media/audio/mac/audio_low_latency_input_mac.cc View 1 chunk +1 line, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +7 lines, -0 lines 3 comments Download

Messages

Total messages: 15 (5 generated)
tommi (sloooow) - chröme
Please take a look. henrika - main reviewer isherman - owner for histograms
4 years, 11 months ago (2016-01-24 16:41:50 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1621313002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1621313002/1
4 years, 11 months ago (2016-01-24 16:42:02 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-24 18:17:22 UTC) #6
henrika (OOO until Aug 14)
I like the idea. Thanks. LGTM.
4 years, 11 months ago (2016-01-25 08:47:55 UTC) #7
henrika (OOO until Aug 14)
https://codereview.chromium.org/1621313002/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/1621313002/diff/1/tools/metrics/histograms/histograms.xml#newcode19059 tools/metrics/histograms/histograms.xml:19059: + Error codes that we encounter while setting up ...
4 years, 11 months ago (2016-01-25 08:48:06 UTC) #8
Ilya Sherman
histograms lgtm https://codereview.chromium.org/1621313002/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/1621313002/diff/1/tools/metrics/histograms/histograms.xml#newcode19056 tools/metrics/histograms/histograms.xml:19056: +<histogram name="Media.InputErrorMac" units="OSStatus"> nit: Should this be ...
4 years, 11 months ago (2016-01-25 19:39:38 UTC) #9
tommi (sloooow) - chröme
https://codereview.chromium.org/1621313002/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/1621313002/diff/1/tools/metrics/histograms/histograms.xml#newcode19056 tools/metrics/histograms/histograms.xml:19056: +<histogram name="Media.InputErrorMac" units="OSStatus"> On 2016/01/25 19:39:38, Ilya Sherman wrote: ...
4 years, 11 months ago (2016-01-25 22:00:14 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1621313002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1621313002/1
4 years, 11 months ago (2016-01-25 22:03:05 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-25 23:57:25 UTC) #13
commit-bot: I haz the power
4 years, 11 months ago (2016-01-26 00:00:54 UTC) #15
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/657a3f6b3e816c7293093dd0b799453dcb947c9b
Cr-Commit-Position: refs/heads/master@{#371351}

Powered by Google App Engine
This is Rietveld 408576698