components/autofill/browser/autofill_external_delegate.h - Issue 16212007: Implement the autofill UI for chromium powered android webview.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/browser/autofill_external_delegate.h

Issue 16212007: Implement the autofill UI for chromium powered android webview. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@issue15097004

Patch Set: introduced java peer to AwAutofillManagerDelegate Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« android_webview/native/aw_autofill_manager_delegate.cc ('K') | « chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillTest.java ('k') | components/autofill/browser/autofill_external_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/browser/autofill_external_delegate.h

diff --git a/components/autofill/browser/autofill_external_delegate.h b/components/autofill/browser/autofill_external_delegate.h

index 1e1acef79650b6b815661f8159ad28d2f11ed757..5a2c3d7678aab040871afc19df308b7ef69089d6 100644

--- a/components/autofill/browser/autofill_external_delegate.h

+++ b/components/autofill/browser/autofill_external_delegate.h

@@ -105,6 +105,9 @@ class AutofillExternalDelegate

const FormFieldData& form,

const PasswordFormFillData& fill_data);

+ // Whether the form data should be saved.

+ virtual bool ShouldSaveFormData(content::WebContents* web_contents);

benm (inactive) 2013/06/17 17:23:17 I don't see caller in this patch?

sgurun-gerrit only 2013/06/25 02:44:32 Done.

protected:

friend class content::WebContentsUserData<AutofillExternalDelegate>;

AutofillExternalDelegate(content::WebContents* web_contents,