Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(661)

Unified Diff: cc/layers/io_surface_layer_impl.cc

Issue 16211002: Skip drawing unsupported layers in forced software mode (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase on r203584 Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/layers/io_surface_layer_impl.cc
diff --git a/cc/layers/io_surface_layer_impl.cc b/cc/layers/io_surface_layer_impl.cc
index 86cb2c75ecd54d9051679d245515723f5444444f..c1f0ab29eb8e120dedad3cdcd58fc140f466eb56 100644
--- a/cc/layers/io_surface_layer_impl.cc
+++ b/cc/layers/io_surface_layer_impl.cc
@@ -61,15 +61,17 @@ void IOSurfaceLayerImpl::PushPropertiesTo(LayerImpl* layer) {
io_surface_layer->SetIOSurfaceProperties(io_surface_id_, io_surface_size_);
}
-void IOSurfaceLayerImpl::WillDraw(ResourceProvider* resource_provider) {
- LayerImpl::WillDraw(resource_provider);
+bool IOSurfaceLayerImpl::WillDraw(DrawMode draw_mode,
+ ResourceProvider* resource_provider) {
+ if (draw_mode == DRAW_MODE_RESOURCELESS_SOFTWARE)
+ return false;
if (io_surface_changed_) {
WebKit::WebGraphicsContext3D* context3d =
resource_provider->GraphicsContext3D();
if (!context3d) {
// FIXME: Implement this path for software compositing.
- return;
+ return false;
}
// FIXME: Do this in a way that we can track memory usage.
@@ -98,6 +100,8 @@ void IOSurfaceLayerImpl::WillDraw(ResourceProvider* resource_provider) {
// has allocated.
io_surface_changed_ = false;
}
+
+ return LayerImpl::WillDraw(draw_mode, resource_provider);
}
void IOSurfaceLayerImpl::AppendQuads(QuadSink* quad_sink,

Powered by Google App Engine
This is Rietveld 408576698