Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Issue 1621013002: Revert of Compute if a layer is drawn without LayerTree hierarchy (Closed)

Created:
4 years, 11 months ago by Nico
Modified:
4 years, 11 months ago
CC:
cc-bugs_chromium.org, chromium-reviews, danakj+watch_chromium.org, jbauman+watch_chromium.org, kalyank, piman+watch_chromium.org, sievers+watch_chromium.org, Ian Vollick
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Compute if a layer is drawn without LayerTree hierarchy (patchset #14 id:250001 of https://codereview.chromium.org/1588093004/ ) Reason for revert: Speculative; might have broken tests on Chrome OS, see http://crbug.com/580806 Original issue's description: > This CL : > * deletes is_hidden > * computes if a layer is drawn using the effect tree > > BUG=575413 > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel > > Committed: https://crrev.com/5bd215b33e6343d8ae7e52fb822dd552bf8b59a7 > Cr-Commit-Position: refs/heads/master@{#371063} TBR=weiliangc@chromium.org,ajuma@chromium.org,enne@chromium.org,vollick@chromium.org,jaydasika@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=575413 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/e53c5270ccb49967bc08e5819a5753713ee3fdc7 Cr-Commit-Position: refs/heads/master@{#371160}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -220 lines) Patch
M cc/layers/layer.h View 1 3 chunks +7 lines, -1 line 0 comments Download
M cc/layers/layer.cc View 1 3 chunks +3 lines, -5 lines 0 comments Download
M cc/layers/layer_impl.h View 1 3 chunks +8 lines, -2 lines 0 comments Download
M cc/layers/layer_impl.cc View 1 6 chunks +8 lines, -15 lines 0 comments Download
M cc/proto/property_tree.proto View 1 1 chunk +3 lines, -7 lines 0 comments Download
M cc/trees/draw_property_utils.cc View 1 5 chunks +11 lines, -12 lines 0 comments Download
M cc/trees/layer_tree_host_common.cc View 1 7 chunks +20 lines, -40 lines 0 comments Download
M cc/trees/layer_tree_host_common_unittest.cc View 1 16 chunks +35 lines, -62 lines 0 comments Download
M cc/trees/occlusion_tracker.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/property_tree.h View 1 2 chunks +0 lines, -7 lines 0 comments Download
M cc/trees/property_tree.cc View 1 5 chunks +1 line, -56 lines 0 comments Download
M cc/trees/property_tree_builder.cc View 1 7 chunks +14 lines, -12 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Nico
Created Revert of Compute if a layer is drawn without LayerTree hierarchy
4 years, 11 months ago (2016-01-23 23:16:27 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1621013002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1621013002/1
4 years, 11 months ago (2016-01-23 23:17:06 UTC) #2
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/149006) ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 11 months ago (2016-01-23 23:19:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1621013002/240001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1621013002/240001
4 years, 11 months ago (2016-01-23 23:28:14 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:240001)
4 years, 11 months ago (2016-01-24 01:20:49 UTC) #8
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/e53c5270ccb49967bc08e5819a5753713ee3fdc7 Cr-Commit-Position: refs/heads/master@{#371160}
4 years, 11 months ago (2016-01-24 01:22:02 UTC) #10
Nico
4 years, 11 months ago (2016-01-24 04:33:53 UTC) #11
Message was sent while issue was closed.
On 2016/01/24 01:22:02, commit-bot: I haz the power wrote:
> Patchset 2 (id:??) landed as
> https://crrev.com/e53c5270ccb49967bc08e5819a5753713ee3fdc7
> Cr-Commit-Position: refs/heads/master@{#371160}

This helped: https://build.chromium.org/p/chromium.chromiumos

Powered by Google App Engine
This is Rietveld 408576698