Issue 16210002: Revert 202926 "Change loading custom auth extension to load from..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16210002: Revert 202926 "Change loading custom auth extension to load from..." (Closed)

Created:
7 years, 6 months ago by Avi (use Gerrit)

Modified:
7 years, 6 months ago

Reviewers:
Tim Song

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 202926 "Change loading custom auth extension to load from..." On suspicions that it turns four CrOS bots red. TBR=tengs@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202964

Patch Set 1 #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -8 lines)			Patch
	M	trunk/src/chrome/browser/extensions/scoped_gaia_auth_extension.cc	View		1 chunk	+1 line, -8 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Avi (use Gerrit)

7 years, 6 months ago (2013-05-29 21:03:33 UTC) #3

Message was sent while issue was closed.

On 2013/05/29 21:01:11, Avi wrote:
> Committed patchset #1 manually as r202964.

Four CrOS bots turned red:

http://build.chromium.org/p/chromium.chromiumos/builders/ChromiumOS%20%28x86%...
http://build.chromium.org/p/chromium.chromiumos/builders/ChromiumOS%20%28amd6...
http://build.chromium.org/p/chromium.memory/builders/Chromium%20OS%20%28x86%2...
http://build.chromium.org/p/chromium.memory/builders/Chromium%20OS%20%28amd64...

tmp.combined-control.Wzl6p/security_ProfilePermissions.login            FAIL:
Exception raised during login: Login failed. Perhaps Chrome crashed, failed to
start, or the login flow is broken? Error message: Chrome automation timed out
after 120 seconds for {"command": "GetNextEvent", "observer_id": -1, "blocking":
true}. See the file named login-fail-screenshot.png in the results folder.
tmp.combined-control.Wzl6p/security_ProfilePermissions.login            05/29
13:15:58.124 ERROR|logging_ma:0579| Fake AddressSanitizer run-time initialized
ok at 0x100000000000
tmp.combined-control.Wzl6p/security_ProfilePermissions.login            05/29
13:18:02.781 ERROR|logging_ma:0579|
[15924:15924:0529/131802:773762203:ERROR:pyautolib.cc(139)] Error during
automation: Chrome automation timed out after 120 seconds for {"command":
"GetNextEvent", "observer_id": -1, "blocking": true}

Expand Messages | Collapse Messages