Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 1620983002: Also transfer pending in-order scripts upon element moving to new document (Closed)

Created:
4 years, 11 months ago by sof
Modified:
4 years, 11 months ago
CC:
chromium-reviews, blink-reviews-html_chromium.org, sof, eae+blinkwatch, fs, kouhei+svg_chromium.org, blink-reviews-dom_chromium.org, dglazkov+blink, krit, f(malita), blink-reviews, gyuyoung2, Stephen Chennney, pdr+svgwatchlist_chromium.org, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Also transfer pending in-order scripts upon element moving to new document Extend the ScriptLoader script runner reassociation that happens when a script element moves to a new document to also include pending in-order scripts. Having this be restricted to async scripts unnecessarily confuses the ScriptLoader when it notifies the ScriptRunner. R=haraken BUG=570012 Committed: https://crrev.com/3cdc8f849d7afb8404e57103dee2e6aa70c4f8f7 Cr-Commit-Position: refs/heads/master@{#371145}

Patch Set 1 #

Patch Set 2 : also remove is-disposed checking; unnecessary #

Messages

Total messages: 10 (5 generated)
sof
please take a look. (a wider reviewer set so as to potentially give this one ...
4 years, 11 months ago (2016-01-23 09:21:47 UTC) #2
haraken
On 2016/01/23 09:21:47, sof wrote: > please take a look. > > (a wider reviewer ...
4 years, 11 months ago (2016-01-23 10:27:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1620983002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1620983002/20001
4 years, 11 months ago (2016-01-23 11:45:37 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-23 23:20:39 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-23 23:22:53 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3cdc8f849d7afb8404e57103dee2e6aa70c4f8f7
Cr-Commit-Position: refs/heads/master@{#371145}

Powered by Google App Engine
This is Rietveld 408576698