final fields shouldn't be dependencies of const variables

final fields shouldn't be dependencies of const variables

(They are only dependencies of const constructors.)

This was causing bogus error messages to appear
when a const expression mistakenly references
a final field.

BUG=https://github.com/dart-lang/sdk/issues/25526
R=brianwilkerson@google.com

Committed: https://github.com/dart-lang/sdk/commit/ccf3870ffcec6f6418dd7471f924be86674f22ce

[skybrian, 2016-01-23 04:06:15]

skybrian@google.com changed reviewers:
+ brianwilkerson@google.com, paulberry@google.com

[skybrian, 2016-01-23 04:07:36]

https://codereview.chromium.org/1620963003/diff/1/pkg/analyzer/test/generated...
File pkg/analyzer/test/generated/compile_time_error_code_test.dart (right):

https://codereview.chromium.org/1620963003/diff/1/pkg/analyzer/test/generated...
pkg/analyzer/test/generated/compile_time_error_code_test.dart:1307:
CompileTimeErrorCode
I believe this is reversing a dartfmt I did with an old version. Sorry about
that.

[Brian Wilkerson, 2016-01-23 17:32:26]

LGTM

https://codereview.chromium.org/1620963003/diff/1/pkg/analyzer/test/generated...
File pkg/analyzer/test/generated/compile_time_error_code_test.dart (right):

https://codereview.chromium.org/1620963003/diff/1/pkg/analyzer/test/generated...
pkg/analyzer/test/generated/compile_time_error_code_test.dart:1269: void
test_constInitializedWithNonConstValue_finalField() {
Seems like we ought to have at least one test of the case where we were
generating a false positive to ensure that we don't regress. (I think it should
go in NonErrorResolverTest.)

https://codereview.chromium.org/1620963003/diff/1/pkg/analyzer/test/generated...
pkg/analyzer/test/generated/compile_time_error_code_test.dart:1307:
CompileTimeErrorCode
No problem. It's unavoidable.

[skybrian, 2016-01-25 23:53:44]

Description was changed from

==========
final fields shouldn't be dependencies of const variables

(They are only dependencies of const constructors.)

This was causing bogus error messages to appear
when a const expression mistakenly references
a final field.

BUG=https://github.com/dart-lang/sdk/issues/25526
==========

to

==========
final fields shouldn't be dependencies of const variables

(They are only dependencies of const constructors.)

This was causing bogus error messages to appear
when a const expression mistakenly references
a final field.

BUG=https://github.com/dart-lang/sdk/issues/25526
R=brianwilkerson@google.com

Committed:
https://github.com/dart-lang/sdk/commit/ccf3870ffcec6f6418dd7471f924be86674f22ce
==========

[skybrian, 2016-01-25 23:53:45]

Committed patchset #1 (id:1) manually as
ccf3870ffcec6f6418dd7471f924be86674f22ce (presubmit successful).

[skybrian, 2016-01-26 02:07:14]

https://codereview.chromium.org/1620963003/diff/1/pkg/analyzer/test/generated...
File pkg/analyzer/test/generated/compile_time_error_code_test.dart (right):

https://codereview.chromium.org/1620963003/diff/1/pkg/analyzer/test/generated...
pkg/analyzer/test/generated/compile_time_error_code_test.dart:1269: void
test_constInitializedWithNonConstValue_finalField() {
On 2016/01/23 17:32:26, Brian Wilkerson wrote:
> Seems like we ought to have at least one test of the case where we were
> generating a false positive to ensure that we don't regress. (I think it
should
> go in NonErrorResolverTest.)


This test is implicitly a regression test. It shows two errors instead of one
error (as expected) if I run it without the fix applied. (Added a comment to
explain this.)

There needs to be a const expression pointing at a final field to reproduce the
bug, so I don't think there's a way to do it using Dart code that has no errors
(which seems to be true of all the tests in NonErrorResolverTest).