Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 1620933002: [Media Router] Fix timing of initially setting margins. (Closed)

Created:
4 years, 11 months ago by apacible
Modified:
4 years, 11 months ago
Reviewers:
imcheng
CC:
chromium-reviews, media-router+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Media Router] Fix timing of initially setting margins. Currently, the sink list view is initially clipped at the top since the top margin styling is being set before the container header is rendered. The first time updateElementPositioning_() is called when the dialog initially is opened should be after the element is attached. BUG=580394 Committed: https://crrev.com/96424f368f476053e4bd957ca5d637299fabef6c Cr-Commit-Position: refs/heads/master@{#371295}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
apacible
PTAL, thanks!
4 years, 11 months ago (2016-01-22 23:37:11 UTC) #4
imcheng
lgtm
4 years, 11 months ago (2016-01-25 18:54:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1620933002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1620933002/1
4 years, 11 months ago (2016-01-25 18:55:46 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-25 20:16:06 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2016-01-25 20:17:25 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/96424f368f476053e4bd957ca5d637299fabef6c
Cr-Commit-Position: refs/heads/master@{#371295}

Powered by Google App Engine
This is Rietveld 408576698