Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Unified Diff: pkg/polymer/lib/src/build/common.dart

Issue 162093002: fix imports link rel=stylesheet (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: trying upload again Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/polymer/lib/src/build/code_extractor.dart ('k') | pkg/polymer/lib/src/build/import_inliner.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/polymer/lib/src/build/common.dart
diff --git a/pkg/polymer/lib/src/build/common.dart b/pkg/polymer/lib/src/build/common.dart
index 7e62cc7adb575dde51b6aa40ddb53e58cb898176..e6b28e2322783e33486bb1bfc0d0a8acf8535edd 100644
--- a/pkg/polymer/lib/src/build/common.dart
+++ b/pkg/polymer/lib/src/build/common.dart
@@ -112,6 +112,13 @@ abstract class PolymerTransformer {
});
}
+ String getAssetUrl(AssetId id, Transform transform) {
Siggi Cherem (dart-lang) 2014/02/13 17:46:33 I find it a bit confusing to have both getAssetUrl
Jennifer Messerly 2014/02/13 20:43:47 done! based Dartdoc on your extremely helpful expl
+ var primaryId = transform.primaryInput.id;
+ bool samePackage = id.package == primaryId.package;
+ return samePackage ? id.path
+ : assetUrlFor(id, primaryId, transform.logger, allowAssetUrl: true);
+ }
+
Future<bool> assetExists(AssetId id, Transform transform) =>
transform.getInput(id).then((_) => true).catchError((_) => false);
@@ -129,7 +136,8 @@ List<List<Transformer>> get phasesForPolymer =>
* urls are not resolved unless [source] is Dart file (has a .dart extension).
*/
// TODO(sigmund): delete once this is part of barback (dartbug.com/12610)
-AssetId resolve(AssetId source, String url, TransformLogger logger, Span span) {
+AssetId resolve(AssetId source, String url, TransformLogger logger, Span span,
+ {bool allowAbsolute: false}) {
if (url == null || url == '') return null;
var uri = Uri.parse(url);
var urlBuilder = path.url;
@@ -142,7 +150,9 @@ AssetId resolve(AssetId source, String url, TransformLogger logger, Span span) {
}
}
- logger.error('absolute paths not allowed: "$url"', span: span);
+ if (!allowAbsolute) {
+ logger.error('absolute paths not allowed: "$url"', span: span);
+ }
return null;
}
« no previous file with comments | « pkg/polymer/lib/src/build/code_extractor.dart ('k') | pkg/polymer/lib/src/build/import_inliner.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698