Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 1620873004: Fix fast string comparison bug. (Closed)

Created:
4 years, 11 months ago by dnj
Modified:
4 years, 11 months ago
Reviewers:
Vadim Sh., iannucci
CC:
chromium-reviews, infra-reviews+luci-gae_chromium.org
Base URL:
https://github.com/luci/gae@master
Target Ref:
refs/heads/master
Project:
luci-gae
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : More fixes, tests. #

Patch Set 3 : Cleaner test. #

Patch Set 4 : Better. #

Patch Set 5 : Less test dups. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -6 lines) Patch
M service/datastore/properties.go View 1 3 chunks +7 lines, -6 lines 0 comments Download
M service/datastore/properties_test.go View 1 2 3 4 2 chunks +77 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
dnj
4 years, 11 months ago (2016-01-22 23:31:54 UTC) #1
iannucci
lgtm lol
4 years, 11 months ago (2016-01-22 23:32:29 UTC) #3
iannucci
On 2016/01/22 23:32:29, iannucci wrote: > lgtm > > lol actually add a test too ...
4 years, 11 months ago (2016-01-22 23:32:49 UTC) #5
Vadim Sh.
stuff like that scares me...
4 years, 11 months ago (2016-01-23 00:02:18 UTC) #7
iannucci
lgtm
4 years, 11 months ago (2016-01-23 00:44:51 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1620873004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1620873004/60001
4 years, 11 months ago (2016-01-23 00:44:55 UTC) #10
iannucci
lgtm
4 years, 11 months ago (2016-01-23 00:46:36 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1620873004/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1620873004/80001
4 years, 11 months ago (2016-01-23 00:46:44 UTC) #14
commit-bot: I haz the power
4 years, 11 months ago (2016-01-23 00:51:02 UTC) #16
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://github.com/luci/gae/commit/139eaf1a2be0c19e798c7c25bc40d24477c2f4e1

Powered by Google App Engine
This is Rietveld 408576698