Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(637)

Issue 1620873003: dart2js cps: Tolerate refinements in more cases. (Closed)

Created:
4 years, 11 months ago by asgerf
Modified:
4 years, 11 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js cps: Tolerate refinements in more cases. Useless branch elimination looks past dead refinements in the branches. Redundant phi elimination ignores refinements, but is followed by an UpdateRefinements pass to restore refinements again. This is a step towards being able to land: https://codereview.chromium.org/1576063003/ FIXES #25448 BUG= R=sra@google.com Committed: https://github.com/dart-lang/sdk/commit/cc1111e23b2573d6946076c7c18e6191ccb58955

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -10 lines) Patch
M pkg/compiler/lib/src/cps_ir/redundant_phi.dart View 3 chunks +5 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/shrinking_reductions.dart View 2 chunks +18 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen/task.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (5 generated)
asgerf
4 years, 11 months ago (2016-01-22 23:24:28 UTC) #5
sra1
lgtm
4 years, 11 months ago (2016-01-23 00:05:23 UTC) #6
asgerf
4 years, 11 months ago (2016-01-23 00:44:20 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
cc1111e23b2573d6946076c7c18e6191ccb58955 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698