Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 162083002: Fix and re-enable NoScriptAccessAfterSwapOut test. (Closed)

Created:
6 years, 10 months ago by Charlie Reis
Modified:
6 years, 10 months ago
Reviewers:
nasko
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Fix and re-enable NoScriptAccessAfterSwapOut test. BUG=261313 TEST=RenderFrameHostManagerTest.NoScriptAccessAfterSwapOut passes. R=nasko@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250909

Patch Set 1 : Initial patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M content/browser/frame_host/render_frame_host_manager_browsertest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/test/data/click-noreferrer-links.html View 1 chunk +7 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Charlie Reis
I was starting to do the SpawnedTestServer change to RFHMBrowserTest so that we can run ...
6 years, 10 months ago (2014-02-12 23:35:23 UTC) #1
nasko
LGTM
6 years, 10 months ago (2014-02-12 23:39:22 UTC) #2
Charlie Reis
The CQ bit was checked by creis@chromium.org
6 years, 10 months ago (2014-02-12 23:46:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/creis@chromium.org/162083002/40001
6 years, 10 months ago (2014-02-12 23:48:03 UTC) #4
Charlie Reis
The CQ bit was unchecked by creis@chromium.org
6 years, 10 months ago (2014-02-13 01:57:51 UTC) #5
Charlie Reis
6 years, 10 months ago (2014-02-13 01:57:53 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 manually as r250909 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698