Issue 16207005: Fix remaining uses of WeakPtr<T>'s operator T* conversion

Issue 16207005: Fix remaining uses of WeakPtr<T>'s operator T* conversion (Closed)

Created:
7 years, 6 months ago by akalin

Modified:
7 years, 6 months ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews, asanka, tburkard+watch_chromium.org, rpetterson, ahutter, gavinp+memory_chromium.org, Albert Bodenhamer, Ilya Sherman, cbentzel+watch_chromium.org, benquan, jam, dbeam+watch-autofill_chromium.org, apatrick_chromium, joi+watch-content_chromium.org, darin-cc_chromium.org, groby+spellwatch_chromium.org, erikwright+watch_chromium.org, tim (not reviewing), Raghu Simha, rouslan+spellwatch_chromium.org, gavinp+prer_chromium.org, Raman Kakilate, haitaol1, feature-media-reviews_chromium.org, benjhayden+dwatch_chromium.org, dominich+watch_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Ryan Sleevi

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix remaining uses of WeakPtr<T>'s operator T* conversion These cases weren't caught by the automated pass and/or needed to be solved in another way than using .get(). BUG=245942 TBR=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203996

Patch Set 1 #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+43 lines, -35 lines)			Patch
M	base/memory/weak_ptr_unittest.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/prerender/prerender_handle.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/spellchecker/spellcheck_hunspell_dictionary.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/spellchecker/spellcheck_service.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/sync/profile_sync_service_unittest.cc	View	4 chunks	+8 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/autofill/autofill_popup_controller_unittest.cc	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	content/browser/download/download_browsertest.cc	View	2 chunks	+4 lines, -2 lines	0 comments	Download
M	gpu/command_buffer/service/context_group.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	media/audio/audio_output_dispatcher_impl.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/quic/quic_stream_factory.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	net/socket/ssl_client_socket_nss.cc	View	2 chunks	+9 lines, -7 lines	0 comments	Download
M	net/spdy/spdy_write_queue_unittest.cc	View	4 chunks	+7 lines, -7 lines	0 comments	Download
M	webkit/browser/quota/quota_manager.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/akalin@chromium.org/16207005/1

7 years, 6 months ago (2013-06-04 16:48:34 UTC) #3

akalin

7 years, 6 months ago (2013-06-04 17:35:29 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r203996 (presubmit successful).

Expand Messages | Collapse Messages