Files.app: Fix errors when launching Files.app via "chrome://files" (2)

chrome/browser/resources/file_manager/js/util.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 'use strict';
 
 /**
  * Namespace for utility functions.
  */
 var util = {};
@@ skipping 786 matching lines @@
    */
   v2: function() {
     try {
       return !!(chrome.app && chrome.app.runtime);
     } catch (e) {
       return false;
     }
   },
 
   /**
+   * @return {boolean} True if the files.app is running as AppsV2. False if

[mtomasz, 2013/06/04 06:38:44]

nit: the files.app -> Files.app (for consistency)

[yoshiki, 2013/06/04 06:57:34]

Done.

+   *     running via "chrome://files".
+   */
+  runningAsApps: function() {

[mtomasz, 2013/06/04 06:38:44]

This naming is confusing. Files.app in chrome://files is also an App V2. How
about renaming to 'runningInBrowser' ?

[yoshiki, 2013/06/04 06:57:34]

Done.

+    if (!util.platform.v2() || !util.platform.newUI())

[mtomasz, 2013/06/04 06:38:44]

Remove util.platform.newUI() check?

[yoshiki, 2013/06/04 06:57:34]

Done.

+      return false;
+    return (window.appID) ? true : false;

[mtomasz, 2013/06/04 06:38:44]

... -> return !!window.appID ?

[yoshiki, 2013/06/04 06:57:34]

Refactored.

+  },
+
+  /**
    * @return {boolean} True for the new ui.
    */
   newUI: function() {
     if (util.platform.newUICached_ === undefined) {
       var manifest = chrome.runtime.getManifest();
       util.platform.newUICached_ = manifest.version >= 3.0;
     }
     return util.platform.newUICached_;
   },
 
@@ skipping 519 matching lines @@
     console.error(
         'App window not passed. Unable to toggle the full screen mode.');
     return;
   }
 
   if (!enabled)
     document.webkitCancelFullScreen();
   else
     document.body.webkitRequestFullScreen();
 };