Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1832)

Unified Diff: net/base/ssl_test_util.h

Issue 16207: Make ssl_client_socket_unittest use a local server (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/base/ssl_client_socket_unittest.cc ('k') | net/base/ssl_test_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/base/ssl_test_util.h
===================================================================
--- net/base/ssl_test_util.h (revision 9822)
+++ net/base/ssl_test_util.h (working copy)
@@ -5,49 +5,98 @@
#ifndef NET_BASE_SSL_TEST_UTIL_H_
#define NET_BASE_SSL_TEST_UTIL_H_
-#include "build/build_config.h"
+#include <string>
#include "base/file_path.h"
+#include "base/process_util.h"
+#include "base/ref_counted.h"
+#include "build/build_config.h"
-// TODO(dkegel): share this between net/base and
+// TODO(dkegel): share this between net/base and
// chrome/browser without putting it in net.lib
-class SSLTestUtil {
+namespace net {
+
+// This object bounds the lifetime of an external python-based HTTP/HTTPS/FTP
+// server that can provide various responses useful for testing.
+// A few basic convenience methods are provided, but no
+// URL handling methods (those belong at a higher layer, e.g. in
+// url_request_unittest.h).
+
+class TestServerLauncher {
public:
- SSLTestUtil();
+ TestServerLauncher();
- ~SSLTestUtil();
+ virtual ~TestServerLauncher();
- FilePath GetRootCertPath();
+ enum Protocol {
+ ProtoHTTP, ProtoFTP
+ };
+ // Start src/net/tools/test_server/test_server.py and
+ // ask it to serve the given protocol.
+ // If protocol is HTTP, and cert_path is not empty, serves HTTPS.
+ // Returns true on success, false if files not found or root cert
+ // not trusted.
+ bool Start(Protocol protocol,
+ const std::string& host_name, int port,
+ const FilePath& document_root,
+ const FilePath& cert_path);
+
+ // Stop the server started by Start().
+ void Stop();
+
+ // Paths to a good, an expired, and an invalid server certificate
+ // (use as arguments to Start()).
FilePath GetOKCertPath();
-
FilePath GetExpiredCertPath();
+ // Issuer name of the root cert that should be trusted for the test to work.
+ static const wchar_t kCertIssuerName[];
+
// Hostname to use for test server
static const char kHostName[];
+ // Different hostname to use for test server (that still resolves to same IP)
+ static const char kMismatchedHostName[];
+
// Port to use for test server
static const int kOKHTTPSPort;
// Port to use for bad test server
static const int kBadHTTPSPort;
- // Issuer name of the cert that should be trusted for the test to work.
- static const wchar_t kCertIssuerName[];
+ private:
+ // Wait a while for the server to start, return whether
+ // we were able to make a connection to it.
+ bool Wait(const std::string& host_name, int port);
+ // Append to PYTHONPATH so Python can find pyftpdlib and tlslite.
+ void SetPythonPath();
+
+ // Path to our test root certificate.
+ FilePath GetRootCertPath();
+
// Returns false if our test root certificate is not trusted.
bool CheckCATrusted();
- private:
+ FilePath data_dir_;
+
FilePath cert_dir_;
+ FilePath python_runtime_;
+
+ base::ProcessHandle process_handle_;
+
#if defined(OS_LINUX)
struct PrivateCERTCertificate;
PrivateCERTCertificate *cert_;
#endif
- DISALLOW_COPY_AND_ASSIGN(SSLTestUtil);
+ DISALLOW_COPY_AND_ASSIGN(TestServerLauncher);
};
-#endif // NET_BASE_SSL_TEST_UTIL_H_
+}
+
+#endif // NET_BASE_SSL_TEST_UTIL_H_
+
« no previous file with comments | « net/base/ssl_client_socket_unittest.cc ('k') | net/base/ssl_test_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698