Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5584)

Unified Diff: chrome/browser/ssl/ssl_uitest.cc

Issue 16207: Make ssl_client_socket_unittest use a local server (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/net/url_fetcher_unittest.cc ('k') | net/base/ssl_client_socket_nss.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ssl/ssl_uitest.cc
===================================================================
--- chrome/browser/ssl/ssl_uitest.cc (revision 9822)
+++ chrome/browser/ssl/ssl_uitest.cc (working copy)
@@ -23,7 +23,6 @@
protected:
SSLUITest() {
dom_automation_enabled_ = true;
- EXPECT_TRUE(util_.CheckCATrusted());
}
TabProxy* GetActiveTabProxy() {
@@ -47,18 +46,14 @@
}
HTTPSTestServer* GoodCertServer() {
- return HTTPSTestServer::CreateServer(util_.kHostName, util_.kOKHTTPSPort,
- kDocRoot, util_.GetOKCertPath().ToWStringHack());
+ return HTTPSTestServer::CreateGoodServer(kDocRoot);
}
HTTPSTestServer* BadCertServer() {
- return HTTPSTestServer::CreateServer(util_.kHostName, util_.kBadHTTPSPort,
- kDocRoot, util_.GetExpiredCertPath().ToWStringHack());
+ return HTTPSTestServer::CreateExpiredServer(kDocRoot);
}
protected:
- SSLTestUtil util_;
-
DISALLOW_COPY_AND_ASSIGN(SSLUITest);
};
@@ -424,8 +419,7 @@
TEST_F(SSLUITest, DISABLED_TestCNInvalidStickiness) {
const std::string kLocalHost = "localhost";
scoped_refptr<HTTPSTestServer> https_server =
- HTTPSTestServer::CreateServer(kLocalHost, util_.kOKHTTPSPort,
- kDocRoot, util_.GetOKCertPath().ToWStringHack());
+ HTTPSTestServer::CreateMismatchedServer(kDocRoot);
ASSERT_TRUE(NULL != https_server.get());
// First we hit the server with hostname, this generates an invalid policy
@@ -462,7 +456,7 @@
ASSERT_TRUE(hostname_index != std::string::npos); // Test sanity check.
std::string new_url;
new_url.append(url.spec().substr(0, hostname_index));
- new_url.append(util_.kHostName);
+ new_url.append(net::TestServerLauncher::kHostName);
new_url.append(url.spec().substr(hostname_index + kLocalHost.size()));
NavigateTab(tab.get(), GURL(new_url));
« no previous file with comments | « chrome/browser/net/url_fetcher_unittest.cc ('k') | net/base/ssl_client_socket_nss.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698