third_party/WebKit/Source/bindings/core/v8/V8Binding.cpp - Issue 1620673002: Remove Blink's ConvertableToTraceFormat

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8Binding.cpp

Issue 1620673002: Remove Blink's ConvertableToTraceFormat (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/V8Binding.h ('k') | third_party/WebKit/Source/core/css/invalidation/InvalidationSet.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/V8Binding.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/V8Binding.cpp b/third_party/WebKit/Source/bindings/core/v8/V8Binding.cpp

index 5186f39f22dd23c7726413a1c1c666916a2825cc..fda660b6f91157f1fe5b3dedbe4f05c88d0fcc72 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V8Binding.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/V8Binding.cpp

@@ -58,7 +58,8 @@

#include "core/loader/FrameLoaderClient.h"

#include "core/workers/WorkerGlobalScope.h"

#include "core/xml/XPathNSResolver.h"

-#include "platform/EventTracer.h"

+#include "platform/JSONValues.h"

+#include "platform/TracedValue.h"

#include "wtf/MainThread.h"

#include "wtf/MathExtras.h"

#include "wtf/StdLibExtras.h"

@@ -948,7 +949,7 @@ String DevToolsFunctionInfo::resourceName() const

return m_resourceName;

}

-PassRefPtr<TraceEvent::ConvertableToTraceFormat> devToolsTraceEventData(v8::Isolate* isolate, ExecutionContext* context, v8::Local<v8::Function> function)

+PassRefPtr<TracedValue> devToolsTraceEventData(v8::Isolate* isolate, ExecutionContext* context, v8::Local<v8::Function> function)

{

DevToolsFunctionInfo info(function);

return InspectorFunctionCallEvent::data(context, info.scriptId(), info.resourceName(), info.lineNumber());