Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Unified Diff: third_party/WebKit/Source/platform/EventTracer.h

Issue 1620673002: Remove Blink's ConvertableToTraceFormat (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/EventTracer.h
diff --git a/third_party/WebKit/Source/platform/EventTracer.h b/third_party/WebKit/Source/platform/EventTracer.h
index d6a4ca85b74f43ced08ef2d05c09f030823d1411..6d812e650cb26de13e4f84bfbc14bb13c0509edf 100644
--- a/third_party/WebKit/Source/platform/EventTracer.h
+++ b/third_party/WebKit/Source/platform/EventTracer.h
@@ -53,17 +53,11 @@ class TraceEventMemoryOverhead;
namespace blink {
+class TracedValue;
+
namespace TraceEvent {
typedef uint64_t TraceEventHandle;
typedef intptr_t TraceEventAPIAtomicWord;
-
-class PLATFORM_EXPORT ConvertableToTraceFormat : public RefCounted<ConvertableToTraceFormat> {
-public:
- virtual String asTraceFormat() const = 0;
- virtual ~ConvertableToTraceFormat() { }
- virtual void estimateTraceMemoryOverhead(base::trace_event::TraceEventMemoryOverhead*) { }
-};
-
} // namespace TraceEvent
// FIXME: Make these global variables thread-safe. Make a value update atomic.
@@ -84,8 +78,8 @@ public:
const char* argNames[],
const unsigned char argTypes[],
const unsigned long long argValues[],
- PassRefPtr<TraceEvent::ConvertableToTraceFormat>,
- PassRefPtr<TraceEvent::ConvertableToTraceFormat>,
+ PassRefPtr<TracedValue>,
+ PassRefPtr<TracedValue>,
unsigned flags);
static TraceEvent::TraceEventHandle addTraceEvent(char phase,
const unsigned char* categoryEnabledFlag,

Powered by Google App Engine
This is Rietveld 408576698