Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(523)

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorTraceEvents.h

Issue 1620673002: Remove Blink's ConvertableToTraceFormat (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/InspectorTraceEvents.h
diff --git a/third_party/WebKit/Source/core/inspector/InspectorTraceEvents.h b/third_party/WebKit/Source/core/inspector/InspectorTraceEvents.h
index 5a27fd6298f93d5da12f3a4d69077e509f7fb05e..e90bcebe1550f4ae65758c812a9536fb890fcf99 100644
--- a/third_party/WebKit/Source/core/inspector/InspectorTraceEvents.h
+++ b/third_party/WebKit/Source/core/inspector/InspectorTraceEvents.h
@@ -9,6 +9,7 @@
#include "core/css/CSSSelector.h"
#include "platform/EventTracer.h"
#include "platform/TraceEvent.h"
+#include "platform/TracedValue.h"
#include "platform/heap/Handle.h"
#include "wtf/Forward.h"
#include "wtf/Functional.h"
@@ -44,13 +45,12 @@ class ResourceRequest;
class ResourceResponse;
class StyleChangeReasonForTracing;
class StyleImage;
-class TracedValue;
class WorkerThread;
class XMLHttpRequest;
namespace InspectorLayoutEvent {
-PassRefPtr<TraceEvent::ConvertableToTraceFormat> beginData(FrameView*);
-PassRefPtr<TraceEvent::ConvertableToTraceFormat> endData(LayoutObject* rootForThisLayout);
+PassRefPtr<TracedValue> beginData(FrameView*);
+PassRefPtr<TracedValue> endData(LayoutObject* rootForThisLayout);
}
namespace InspectorScheduleStyleInvalidationTrackingEvent {
@@ -59,10 +59,10 @@ extern const char Class[];
extern const char Id[];
extern const char Pseudo[];
-PassRefPtr<TraceEvent::ConvertableToTraceFormat> attributeChange(Element&, const InvalidationSet&, const QualifiedName&);
-PassRefPtr<TraceEvent::ConvertableToTraceFormat> classChange(Element&, const InvalidationSet&, const AtomicString&);
-PassRefPtr<TraceEvent::ConvertableToTraceFormat> idChange(Element&, const InvalidationSet&, const AtomicString&);
-PassRefPtr<TraceEvent::ConvertableToTraceFormat> pseudoChange(Element&, const InvalidationSet&, CSSSelector::PseudoType);
+PassRefPtr<TracedValue> attributeChange(Element&, const InvalidationSet&, const QualifiedName&);
+PassRefPtr<TracedValue> classChange(Element&, const InvalidationSet&, const AtomicString&);
+PassRefPtr<TracedValue> idChange(Element&, const InvalidationSet&, const AtomicString&);
+PassRefPtr<TracedValue> pseudoChange(Element&, const InvalidationSet&, CSSSelector::PseudoType);
} // namespace InspectorScheduleStyleInvalidationTrackingEvent
#define TRACE_SCHEDULE_STYLE_INVALIDATION(element, invalidationSet, changeType, ...) \
@@ -74,7 +74,7 @@ PassRefPtr<TraceEvent::ConvertableToTraceFormat> pseudoChange(Element&, const In
InspectorScheduleStyleInvalidationTrackingEvent::changeType((element), (invalidationSet), __VA_ARGS__));
namespace InspectorStyleRecalcInvalidationTrackingEvent {
-PassRefPtr<TraceEvent::ConvertableToTraceFormat> data(Node*, const StyleChangeReasonForTracing&);
+PassRefPtr<TracedValue> data(Node*, const StyleChangeReasonForTracing&);
}
String descendantInvalidationSetToIdString(const InvalidationSet&);
@@ -88,9 +88,9 @@ extern const char InvalidationSetMatchedId[];
extern const char InvalidationSetMatchedTagName[];
extern const char PreventStyleSharingForParent[];
-PassRefPtr<TraceEvent::ConvertableToTraceFormat> data(Element&, const char* reason);
-PassRefPtr<TraceEvent::ConvertableToTraceFormat> selectorPart(Element&, const char* reason, const InvalidationSet&, const String&);
-PassRefPtr<TraceEvent::ConvertableToTraceFormat> invalidationList(Element&, const Vector<RefPtr<InvalidationSet>>&);
+PassRefPtr<TracedValue> data(Element&, const char* reason);
+PassRefPtr<TracedValue> selectorPart(Element&, const char* reason, const InvalidationSet&, const String&);
+PassRefPtr<TracedValue> invalidationList(Element&, const Vector<RefPtr<InvalidationSet>>&);
} // namespace InspectorStyleInvalidatorInvalidateEvent
#define TRACE_STYLE_INVALIDATOR_INVALIDATION(element, reason) \
@@ -153,76 +153,76 @@ extern const char ScrollbarChanged[];
typedef const char LayoutInvalidationReasonForTracing[];
namespace InspectorLayoutInvalidationTrackingEvent {
-PassRefPtr<TraceEvent::ConvertableToTraceFormat> CORE_EXPORT data(const LayoutObject*, LayoutInvalidationReasonForTracing);
+PassRefPtr<TracedValue> CORE_EXPORT data(const LayoutObject*, LayoutInvalidationReasonForTracing);
}
namespace InspectorPaintInvalidationTrackingEvent {
-PassRefPtr<TraceEvent::ConvertableToTraceFormat> data(const LayoutObject*, const LayoutObject& paintContainer);
+PassRefPtr<TracedValue> data(const LayoutObject*, const LayoutObject& paintContainer);
}
namespace InspectorScrollInvalidationTrackingEvent {
-PassRefPtr<TraceEvent::ConvertableToTraceFormat> data(const LayoutObject&);
+PassRefPtr<TracedValue> data(const LayoutObject&);
}
namespace InspectorSendRequestEvent {
-PassRefPtr<TraceEvent::ConvertableToTraceFormat> data(unsigned long identifier, LocalFrame*, const ResourceRequest&);
+PassRefPtr<TracedValue> data(unsigned long identifier, LocalFrame*, const ResourceRequest&);
}
namespace InspectorReceiveResponseEvent {
-PassRefPtr<TraceEvent::ConvertableToTraceFormat> data(unsigned long identifier, LocalFrame*, const ResourceResponse&);
+PassRefPtr<TracedValue> data(unsigned long identifier, LocalFrame*, const ResourceResponse&);
}
namespace InspectorReceiveDataEvent {
-PassRefPtr<TraceEvent::ConvertableToTraceFormat> data(unsigned long identifier, LocalFrame*, int encodedDataLength);
+PassRefPtr<TracedValue> data(unsigned long identifier, LocalFrame*, int encodedDataLength);
}
namespace InspectorResourceFinishEvent {
-PassRefPtr<TraceEvent::ConvertableToTraceFormat> data(unsigned long identifier, double finishTime, bool didFail);
+PassRefPtr<TracedValue> data(unsigned long identifier, double finishTime, bool didFail);
}
namespace InspectorTimerInstallEvent {
-PassRefPtr<TraceEvent::ConvertableToTraceFormat> data(ExecutionContext*, int timerId, int timeout, bool singleShot);
+PassRefPtr<TracedValue> data(ExecutionContext*, int timerId, int timeout, bool singleShot);
}
namespace InspectorTimerRemoveEvent {
-PassRefPtr<TraceEvent::ConvertableToTraceFormat> data(ExecutionContext*, int timerId);
+PassRefPtr<TracedValue> data(ExecutionContext*, int timerId);
}
namespace InspectorTimerFireEvent {
-PassRefPtr<TraceEvent::ConvertableToTraceFormat> data(ExecutionContext*, int timerId);
+PassRefPtr<TracedValue> data(ExecutionContext*, int timerId);
}
namespace InspectorIdleCallbackRequestEvent {
-PassRefPtr<TraceEvent::ConvertableToTraceFormat> data(ExecutionContext*, int id, double timeout);
+PassRefPtr<TracedValue> data(ExecutionContext*, int id, double timeout);
}
namespace InspectorIdleCallbackCancelEvent {
-PassRefPtr<TraceEvent::ConvertableToTraceFormat> data(ExecutionContext*, int id);
+PassRefPtr<TracedValue> data(ExecutionContext*, int id);
}
namespace InspectorIdleCallbackFireEvent {
-PassRefPtr<TraceEvent::ConvertableToTraceFormat> data(ExecutionContext*, int id, double allottedMilliseconds, bool timedOut);
+PassRefPtr<TracedValue> data(ExecutionContext*, int id, double allottedMilliseconds, bool timedOut);
}
namespace InspectorAnimationFrameEvent {
-PassRefPtr<TraceEvent::ConvertableToTraceFormat> data(ExecutionContext*, int callbackId);
+PassRefPtr<TracedValue> data(ExecutionContext*, int callbackId);
}
namespace InspectorParseHtmlEvent {
-PassRefPtr<TraceEvent::ConvertableToTraceFormat> beginData(Document*, unsigned startLine);
-PassRefPtr<TraceEvent::ConvertableToTraceFormat> endData(unsigned endLine);
+PassRefPtr<TracedValue> beginData(Document*, unsigned startLine);
+PassRefPtr<TracedValue> endData(unsigned endLine);
}
namespace InspectorParseAuthorStyleSheetEvent {
-PassRefPtr<TraceEvent::ConvertableToTraceFormat> data(const CSSStyleSheetResource*);
+PassRefPtr<TracedValue> data(const CSSStyleSheetResource*);
}
namespace InspectorXhrReadyStateChangeEvent {
-PassRefPtr<TraceEvent::ConvertableToTraceFormat> data(ExecutionContext*, XMLHttpRequest*);
+PassRefPtr<TracedValue> data(ExecutionContext*, XMLHttpRequest*);
}
namespace InspectorXhrLoadEvent {
-PassRefPtr<TraceEvent::ConvertableToTraceFormat> data(ExecutionContext*, XMLHttpRequest*);
+PassRefPtr<TracedValue> data(ExecutionContext*, XMLHttpRequest*);
}
namespace InspectorLayerInvalidationTrackingEvent {
@@ -232,7 +232,7 @@ extern const char RemovedFromSquashingLayer[];
extern const char ReflectionLayerChanged[];
extern const char NewCompositedLayer[];
-PassRefPtr<TraceEvent::ConvertableToTraceFormat> data(const PaintLayer*, const char* reason);
+PassRefPtr<TracedValue> data(const PaintLayer*, const char* reason);
}
#define TRACE_LAYER_INVALIDATION(LAYER, REASON) \
@@ -244,85 +244,85 @@ PassRefPtr<TraceEvent::ConvertableToTraceFormat> data(const PaintLayer*, const c
InspectorLayerInvalidationTrackingEvent::data((LAYER), (REASON)));
namespace InspectorPaintEvent {
-PassRefPtr<TraceEvent::ConvertableToTraceFormat> data(LayoutObject*, const LayoutRect& clipRect, const GraphicsLayer*);
+PassRefPtr<TracedValue> data(LayoutObject*, const LayoutRect& clipRect, const GraphicsLayer*);
}
namespace InspectorPaintImageEvent {
-PassRefPtr<TraceEvent::ConvertableToTraceFormat> data(const LayoutImage&);
-PassRefPtr<TraceEvent::ConvertableToTraceFormat> data(const LayoutObject&, const StyleImage&);
-PassRefPtr<TraceEvent::ConvertableToTraceFormat> data(const LayoutObject*, const ImageResource&);
+PassRefPtr<TracedValue> data(const LayoutImage&);
+PassRefPtr<TracedValue> data(const LayoutObject&, const StyleImage&);
+PassRefPtr<TracedValue> data(const LayoutObject*, const ImageResource&);
}
namespace InspectorCommitLoadEvent {
-PassRefPtr<TraceEvent::ConvertableToTraceFormat> data(LocalFrame*);
+PassRefPtr<TracedValue> data(LocalFrame*);
}
namespace InspectorMarkLoadEvent {
-PassRefPtr<TraceEvent::ConvertableToTraceFormat> data(LocalFrame*);
+PassRefPtr<TracedValue> data(LocalFrame*);
}
namespace InspectorScrollLayerEvent {
-PassRefPtr<TraceEvent::ConvertableToTraceFormat> data(LayoutObject*);
+PassRefPtr<TracedValue> data(LayoutObject*);
}
namespace InspectorUpdateLayerTreeEvent {
-PassRefPtr<TraceEvent::ConvertableToTraceFormat> data(LocalFrame*);
+PassRefPtr<TracedValue> data(LocalFrame*);
}
namespace InspectorEvaluateScriptEvent {
-PassRefPtr<TraceEvent::ConvertableToTraceFormat> data(LocalFrame*, const String& url, const WTF::TextPosition&);
+PassRefPtr<TracedValue> data(LocalFrame*, const String& url, const WTF::TextPosition&);
}
namespace InspectorCompileScriptEvent {
-PassRefPtr<TraceEvent::ConvertableToTraceFormat> data(const String& url, const WTF::TextPosition&);
+PassRefPtr<TracedValue> data(const String& url, const WTF::TextPosition&);
}
namespace InspectorFunctionCallEvent {
-PassRefPtr<TraceEvent::ConvertableToTraceFormat> data(ExecutionContext*, int scriptId, const String& scriptName, int scriptLine);
+PassRefPtr<TracedValue> data(ExecutionContext*, int scriptId, const String& scriptName, int scriptLine);
}
namespace InspectorUpdateCountersEvent {
-PassRefPtr<TraceEvent::ConvertableToTraceFormat> data();
+PassRefPtr<TracedValue> data();
}
namespace InspectorInvalidateLayoutEvent {
-PassRefPtr<TraceEvent::ConvertableToTraceFormat> data(LocalFrame*);
+PassRefPtr<TracedValue> data(LocalFrame*);
}
namespace InspectorRecalculateStylesEvent {
-PassRefPtr<TraceEvent::ConvertableToTraceFormat> data(LocalFrame*);
+PassRefPtr<TracedValue> data(LocalFrame*);
}
namespace InspectorEventDispatchEvent {
-PassRefPtr<TraceEvent::ConvertableToTraceFormat> data(const Event&);
+PassRefPtr<TracedValue> data(const Event&);
}
namespace InspectorTimeStampEvent {
-PassRefPtr<TraceEvent::ConvertableToTraceFormat> data(ExecutionContext*, const String& message);
+PassRefPtr<TracedValue> data(ExecutionContext*, const String& message);
}
namespace InspectorTracingSessionIdForWorkerEvent {
-PassRefPtr<TraceEvent::ConvertableToTraceFormat> data(const String& sessionId, const String& workerId, WorkerThread*);
+PassRefPtr<TracedValue> data(const String& sessionId, const String& workerId, WorkerThread*);
}
namespace InspectorTracingStartedInFrame {
-PassRefPtr<TraceEvent::ConvertableToTraceFormat> data(const String& sessionId, LocalFrame*);
+PassRefPtr<TracedValue> data(const String& sessionId, LocalFrame*);
}
namespace InspectorSetLayerTreeId {
-PassRefPtr<TraceEvent::ConvertableToTraceFormat> data(const String& sessionId, int layerTreeId);
+PassRefPtr<TracedValue> data(const String& sessionId, int layerTreeId);
}
namespace InspectorAnimationEvent {
-PassRefPtr<TraceEvent::ConvertableToTraceFormat> data(const Animation&);
+PassRefPtr<TracedValue> data(const Animation&);
}
namespace InspectorAnimationStateEvent {
-PassRefPtr<TraceEvent::ConvertableToTraceFormat> data(const Animation&);
+PassRefPtr<TracedValue> data(const Animation&);
}
namespace InspectorHitTestEvent {
-PassRefPtr<TraceEvent::ConvertableToTraceFormat> endData(const HitTestRequest&, const HitTestLocation&, const HitTestResult&);
+PassRefPtr<TracedValue> endData(const HitTestRequest&, const HitTestLocation&, const HitTestResult&);
}
CORE_EXPORT String toHexString(const void* p);

Powered by Google App Engine
This is Rietveld 408576698