Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Unified Diff: third_party/WebKit/Source/platform/TracedValue.h

Issue 1620673002: Remove Blink's ConvertableToTraceFormat (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/TracedValue.h
diff --git a/third_party/WebKit/Source/platform/TracedValue.h b/third_party/WebKit/Source/platform/TracedValue.h
index 89b2d6e0905d21aafcee8712d49d9e4217f5183d..0bbef5adf2bb5ee59c63f5f912d1b7e04afe0990 100644
--- a/third_party/WebKit/Source/platform/TracedValue.h
+++ b/third_party/WebKit/Source/platform/TracedValue.h
@@ -19,10 +19,12 @@ class TracedValue;
namespace blink {
// TracedValue copies all passed names and values and doesn't retain references.
-class PLATFORM_EXPORT TracedValue : public TraceEvent::ConvertableToTraceFormat {
+class PLATFORM_EXPORT TracedValue : public RefCounted<TracedValue> {
hiroshige 2016/01/28 12:05:01 TracedValue should be final (or ~TracedValue() sho
bashi 2016/01/29 02:25:26 Done.
WTF_MAKE_NONCOPYABLE(TracedValue);
public:
+ ~TracedValue();
+
static PassRefPtr<TracedValue> create();
void endDictionary();
@@ -42,14 +44,14 @@ public:
void beginArray();
void beginDictionary();
- String asTraceFormat() const override;
- void estimateTraceMemoryOverhead(base::trace_event::TraceEventMemoryOverhead*) override;
+ String toString() const;
private:
TracedValue();
- ~TracedValue() override;
scoped_refptr<base::trace_event::TracedValue> m_tracedValue;
+
+ friend class EventTracer;
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698