Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Side by Side Diff: third_party/WebKit/Source/platform/TracedValue.cpp

Issue 1620673002: Remove Blink's ConvertableToTraceFormat (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "platform/TracedValue.h" 5 #include "platform/TracedValue.h"
6 6
7 #include "base/trace_event/trace_event_argument.h" 7 #include "base/trace_event/trace_event_argument.h"
8 #include "wtf/text/StringUTF8Adaptor.h" 8 #include "wtf/text/StringUTF8Adaptor.h"
9 9
10 namespace blink { 10 namespace blink {
11 11
12 PassRefPtr<TracedValue> TracedValue::create() 12 PassRefPtr<TracedValue> TracedValue::create()
13 { 13 {
14 return adoptRef(new TracedValue()); 14 return adoptRef(new TracedValue());
15 } 15 }
16 16
17 TracedValue::TracedValue() 17 TracedValue::TracedValue()
18 : m_tracedValue(new base::trace_event::TracedValue) 18 : m_tracedValue(new base::trace_event::TracedValue)
19 { 19 {
20 } 20 }
21 21
22 TracedValue::~TracedValue() 22 TracedValue::~TracedValue()
23 { 23 {
24 } 24 }
25 25
26 void TracedValue::setInteger(const char* name, int value) 26 void TracedValue::setInteger(const char* name, int value)
27 { 27 {
28 ASSERT(m_tracedValue.get());
28 m_tracedValue->SetIntegerWithCopiedName(name, value); 29 m_tracedValue->SetIntegerWithCopiedName(name, value);
29 } 30 }
30 31
31 void TracedValue::setDouble(const char* name, double value) 32 void TracedValue::setDouble(const char* name, double value)
32 { 33 {
34 ASSERT(m_tracedValue.get());
33 m_tracedValue->SetDoubleWithCopiedName(name, value); 35 m_tracedValue->SetDoubleWithCopiedName(name, value);
34 } 36 }
35 37
36 void TracedValue::setBoolean(const char* name, bool value) 38 void TracedValue::setBoolean(const char* name, bool value)
37 { 39 {
40 ASSERT(m_tracedValue.get());
38 m_tracedValue->SetBooleanWithCopiedName(name, value); 41 m_tracedValue->SetBooleanWithCopiedName(name, value);
39 } 42 }
40 43
41 void TracedValue::setString(const char* name, const String& value) 44 void TracedValue::setString(const char* name, const String& value)
42 { 45 {
46 ASSERT(m_tracedValue.get());
43 StringUTF8Adaptor adaptor(value); 47 StringUTF8Adaptor adaptor(value);
44 m_tracedValue->SetStringWithCopiedName(name, adaptor.asStringPiece()); 48 m_tracedValue->SetStringWithCopiedName(name, adaptor.asStringPiece());
45 } 49 }
46 50
47 void TracedValue::beginDictionary(const char* name) 51 void TracedValue::beginDictionary(const char* name)
48 { 52 {
53 ASSERT(m_tracedValue.get());
49 m_tracedValue->BeginDictionaryWithCopiedName(name); 54 m_tracedValue->BeginDictionaryWithCopiedName(name);
50 } 55 }
51 56
52 void TracedValue::beginArray(const char* name) 57 void TracedValue::beginArray(const char* name)
53 { 58 {
59 ASSERT(m_tracedValue.get());
54 m_tracedValue->BeginArrayWithCopiedName(name); 60 m_tracedValue->BeginArrayWithCopiedName(name);
55 } 61 }
56 62
57 void TracedValue::endDictionary() 63 void TracedValue::endDictionary()
58 { 64 {
65 ASSERT(m_tracedValue.get());
59 m_tracedValue->EndDictionary(); 66 m_tracedValue->EndDictionary();
60 } 67 }
61 68
62 void TracedValue::pushInteger(int value) 69 void TracedValue::pushInteger(int value)
63 { 70 {
71 ASSERT(m_tracedValue.get());
64 m_tracedValue->AppendInteger(value); 72 m_tracedValue->AppendInteger(value);
65 } 73 }
66 74
67 void TracedValue::pushDouble(double value) 75 void TracedValue::pushDouble(double value)
68 { 76 {
77 ASSERT(m_tracedValue.get());
69 m_tracedValue->AppendDouble(value); 78 m_tracedValue->AppendDouble(value);
70 } 79 }
71 80
72 void TracedValue::pushBoolean(bool value) 81 void TracedValue::pushBoolean(bool value)
73 { 82 {
83 ASSERT(m_tracedValue.get());
74 m_tracedValue->AppendBoolean(value); 84 m_tracedValue->AppendBoolean(value);
75 } 85 }
76 86
77 void TracedValue::pushString(const String& value) 87 void TracedValue::pushString(const String& value)
78 { 88 {
89 ASSERT(m_tracedValue.get());
79 StringUTF8Adaptor adaptor(value); 90 StringUTF8Adaptor adaptor(value);
80 m_tracedValue->AppendString(adaptor.asStringPiece()); 91 m_tracedValue->AppendString(adaptor.asStringPiece());
81 } 92 }
82 93
83 void TracedValue::beginArray() 94 void TracedValue::beginArray()
84 { 95 {
96 ASSERT(m_tracedValue.get());
85 m_tracedValue->BeginArray(); 97 m_tracedValue->BeginArray();
86 } 98 }
87 99
88 void TracedValue::beginDictionary() 100 void TracedValue::beginDictionary()
89 { 101 {
102 ASSERT(m_tracedValue.get());
90 m_tracedValue->BeginDictionary(); 103 m_tracedValue->BeginDictionary();
91 } 104 }
92 105
93 void TracedValue::endArray() 106 void TracedValue::endArray()
94 { 107 {
108 ASSERT(m_tracedValue.get());
95 m_tracedValue->EndArray(); 109 m_tracedValue->EndArray();
96 } 110 }
97 111
98 String TracedValue::asTraceFormat() const 112 String TracedValue::toString() const
99 { 113 {
114 ASSERT(m_tracedValue.get());
100 std::string out; 115 std::string out;
101 m_tracedValue->AppendAsTraceFormat(&out); 116 m_tracedValue->AppendAsTraceFormat(&out);
102 return String::fromUTF8(out.c_str()); 117 return String::fromUTF8(out.c_str());
103 } 118 }
104 119
105 void TracedValue::estimateTraceMemoryOverhead(base::trace_event::TraceEventMemor yOverhead* overhead)
106 {
107 m_tracedValue->EstimateTraceMemoryOverhead(overhead);
108 }
109
110 } // namespace blink 120 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/platform/TracedValue.h ('k') | third_party/WebKit/Source/platform/TracedValueTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698