Pass Only the Pasted Text to Spellchecker

Pass Only the Pasted Text to Spellchecker

Without this patch, the root editable element is passed to spellchecker
after pasting, which results in a long running time if we paste some short
text into an editor that already has a large amount of text.

This patch passes the range of the pasted text only, which significantly
reduces the time spent on spellchecking in the above scenario.

BUG=109587
Committed: https://crrev.com/c3cb0dce8a7f1a4a72b82b76945a7e709f93d7e4
Cr-Commit-Position: refs/heads/master@{#370946}

[Xiaocheng, 2016-01-22 08:49:22]

xiaochengh@chromium.org changed reviewers:
+ yosin@chromium.org

[Xiaocheng, 2016-01-22 08:49:23]

PTAL.

[yosin_UTC9, 2016-01-22 09:56:55]

lgtm w/ small nits.

Please add:
TEST=n/a; this changes doesn't behavior.

https://codereview.chromium.org/1620653002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/Editor.cpp (right):

https://codereview.chromium.org/1620653002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/Editor.cpp:518: if
(insertedRange.isNotNull())
nit: early return style is better.

https://codereview.chromium.org/1620653002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.h
(right):

https://codereview.chromium.org/1620653002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.h:55:
EphemeralRange insertedRange() { return EphemeralRange(m_startOfInsertedRange,
m_endOfInsertedRange); }
nit: This member function should be marked with |const|.
nit: Please move this function to cpp file.

[Xiaocheng, 2016-01-22 10:24:37]

Committing with nits fixed.

https://codereview.chromium.org/1620653002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/Editor.cpp (right):

https://codereview.chromium.org/1620653002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/Editor.cpp:518: if
(insertedRange.isNotNull())
On 2016/01/22 at 09:56:55, Yosi_UTC9 wrote:
> nit: early return style is better.

Done.

https://codereview.chromium.org/1620653002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.h
(right):

https://codereview.chromium.org/1620653002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.h:55:
EphemeralRange insertedRange() { return EphemeralRange(m_startOfInsertedRange,
m_endOfInsertedRange); }
On 2016/01/22 at 09:56:55, Yosi_UTC9 wrote:
> nit: This member function should be marked with |const|.
> nit: Please move this function to cpp file.

Done.

[Xiaocheng, 2016-01-22 10:25:00]

The CQ bit was checked by xiaochengh@chromium.org

[Xiaocheng, 2016-01-22 10:25:00]

The patchset sent to the CQ was uploaded after l-g-t-m from yosin@chromium.org
Link to the patchset: https://codereview.chromium.org/1620653002/#ps20001
(title: " ")

[commit-bot: I haz the power, 2016-01-22 10:25:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1620653002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1620653002/20001

[commit-bot: I haz the power, 2016-01-22 11:49:13]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-22 11:50:11]

Description was changed from

==========
Pass Only the Pasted Text to Spellchecker

Without this patch, the root editable element is passed to spellchecker
after pasting, which results in a long running time if we paste some short
text into an editor that already has a large amount of text.

This patch passes the range of the pasted text only, which significantly
reduces the time spent on spellchecking in the above scenario.

BUG=109587
==========

to

==========
Pass Only the Pasted Text to Spellchecker

Without this patch, the root editable element is passed to spellchecker
after pasting, which results in a long running time if we paste some short
text into an editor that already has a large amount of text.

This patch passes the range of the pasted text only, which significantly
reduces the time spent on spellchecking in the above scenario.

BUG=109587

Committed: https://crrev.com/c3cb0dce8a7f1a4a72b82b76945a7e709f93d7e4
Cr-Commit-Position: refs/heads/master@{#370946}
==========

[commit-bot: I haz the power, 2016-01-22 11:50:12]

Patchset 2 (id:??) landed as
https://crrev.com/c3cb0dce8a7f1a4a72b82b76945a7e709f93d7e4
Cr-Commit-Position: refs/heads/master@{#370946}