Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 16206007: Turn off allocation site info for crankshafted array constructor calls. (Closed)

Created:
7 years, 6 months ago by mvstanton
Modified:
7 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

Turn off allocation site info for crankshafted array constructor calls. Once we crankshaft a method, we should turn off allocation site info for constructed arrays. Additionally, the semantics for doing this were awkward because the constructed array code stubs get an AllocationSiteMode as a minor key, but it's used as a permission to determine the final mode locally based on ElementsKind. I refactored this to a simpler boolean for override or local control. BUG= R=hpayer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=14934

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -33 lines) Patch
M src/arm/code-stubs-arm.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 chunk +6 lines, -3 lines 0 comments Download
M src/code-stubs.h View 5 chunks +16 lines, -13 lines 2 comments Download
M src/code-stubs-hydrogen.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/hydrogen.h View 1 chunk +1 line, -1 line 0 comments Download
M src/hydrogen.cc View 1 chunk +4 lines, -6 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 chunk +5 lines, -1 line 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +6 lines, -3 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
mvstanton
Hi Hannes, here is the code we discussed, thanks! --Michael
7 years, 6 months ago (2013-06-04 11:32:04 UTC) #1
Hannes Payer (out of office)
LGTM! Renaming nits. https://codereview.chromium.org/16206007/diff/1/src/code-stubs.h File src/code-stubs.h (right): https://codereview.chromium.org/16206007/diff/1/src/code-stubs.h#newcode1701 src/code-stubs.h:1701: bool disable_allocation_sites() const { This is ...
7 years, 6 months ago (2013-06-04 12:25:54 UTC) #2
mvstanton
7 years, 6 months ago (2013-06-04 12:49:01 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r14934 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698