Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(449)

Issue 1620583002: Revert "clang: Makes builds with clang less dependent on absolute file path" (Closed)

Created:
4 years, 11 months ago by dsansome
Modified:
4 years, 11 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "clang: Makes builds with clang less dependent on absolute file path" This reverts commit fdca0741b22a4dddbf1808b8d0081651662b22c5. This seems to break codesearch grok indexing. BUG=580103 TBR=brettw Committed: https://crrev.com/f6ea5e493b26f559ee94fcdd5b7e9a4727c62587 Cr-Commit-Position: refs/heads/master@{#370919}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -26 lines) Patch
M build/config/compiler/BUILD.gn View 1 chunk +0 lines, -9 lines 0 comments Download
M build/config/linux/pkg_config.gni View 1 chunk +1 line, -1 line 0 comments Download
M build/config/posix/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M build/config/sysroot.gni View 3 chunks +11 lines, -13 lines 0 comments Download
M printing/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
dsansome
4 years, 11 months ago (2016-01-22 05:43:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1620583002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1620583002/1
4 years, 11 months ago (2016-01-22 05:44:20 UTC) #6
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
4 years, 11 months ago (2016-01-22 05:44:21 UTC) #8
dsansome
4 years, 11 months ago (2016-01-22 06:00:34 UTC) #10
Mike Lawther (Google)
On 2016/01/22 06:00:34, dsansome wrote: lgtm
4 years, 11 months ago (2016-01-22 06:02:10 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1620583002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1620583002/1
4 years, 11 months ago (2016-01-22 06:03:12 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-22 07:21:32 UTC) #15
commit-bot: I haz the power
4 years, 11 months ago (2016-01-22 07:22:30 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f6ea5e493b26f559ee94fcdd5b7e9a4727c62587
Cr-Commit-Position: refs/heads/master@{#370919}

Powered by Google App Engine
This is Rietveld 408576698