Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 1620523002: Change _PDF_RenderItem to CPDF_RenderContext::Layer. (Closed)

Created:
4 years, 11 months ago by Tom Sepez
Modified:
4 years, 11 months ago
Reviewers:
Oliver Chang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Change _PDF_RenderItem to CPDF_RenderContext::Layer. The _CAPS class naming convention violates reserved identifier rules. R=ochang@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/d5712ac571f3487fe3f74617fdab007a11a09052

Patch Set 1 #

Patch Set 2 : Few more unused decls #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -92 lines) Patch
M core/include/fpdfapi/fpdf_render.h View 1 2 chunks +23 lines, -29 lines 0 comments Download
M core/src/fpdfapi/fpdf_render/fpdf_render.cpp View 1 13 chunks +43 lines, -45 lines 0 comments Download
M core/src/fpdfapi/fpdf_render/fpdf_render_image.cpp View 3 chunks +4 lines, -3 lines 0 comments Download
M core/src/fpdfapi/fpdf_render/fpdf_render_pattern.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M core/src/fpdfapi/fpdf_render/render_int.h View 1 chunk +0 lines, -7 lines 0 comments Download
M core/src/fpdfdoc/doc_annot.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M core/src/fpdfdoc/doc_formcontrol.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M fpdfsdk/src/fpdfview.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (4 generated)
Tom Sepez
Oliver, more tidying. This makes more sense to me.
4 years, 11 months ago (2016-01-22 18:02:51 UTC) #2
Oliver Chang
lgtm
4 years, 11 months ago (2016-01-22 19:12:40 UTC) #5
Tom Sepez
4 years, 11 months ago (2016-01-22 20:01:03 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
d5712ac571f3487fe3f74617fdab007a11a09052 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698