Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 1620453002: Disable incremental resolution for constructor parameter names changes. (Closed)

Created:
4 years, 11 months ago by scheglov
Modified:
4 years, 11 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Disable incremental resolution for constructor parameter names changes. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/068b8865433020da80132513c393313fad2944d3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -43 lines) Patch
M pkg/analyzer/lib/src/generated/incremental_resolver.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analyzer/test/generated/incremental_resolver_test.dart View 6 chunks +49 lines, -42 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 11 months ago (2016-01-21 22:26:13 UTC) #1
Brian Wilkerson
LGTM
4 years, 11 months ago (2016-01-21 22:32:43 UTC) #2
scheglov
4 years, 11 months ago (2016-01-21 22:33:48 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
068b8865433020da80132513c393313fad2944d3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698