Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 1620393002: Fix hyphen disallowed in Suborigin names (Closed)

Created:
4 years, 11 months ago by jww
Modified:
4 years, 11 months ago
Reviewers:
Mike West
CC:
blink-reviews, chromium-reviews, mkwst+watchlist-csp_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix hyphen disallowed in Suborigin names According to the proposed spec, Suborigin names should allow alphanumeric characters and hyphens. This fixes a bug where hyphens were disallowed, and it adds tests to verify the behavior. BUG=568755 R=mkwst@chromium.org Committed: https://crrev.com/45a6c6950aa8dd41d710664b7bf020b8c6da8410 Cr-Commit-Position: refs/heads/master@{#371381}

Patch Set 1 #

Patch Set 2 : Rebase on ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M third_party/WebKit/LayoutTests/http/tests/security/suborigins/suborigin-valid-names.html View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/suborigins/suborigin-valid-names-expected.txt View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/csp/CSPDirectiveList.cpp View 1 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
jww
Mike, can you take a quick look at this?
4 years, 11 months ago (2016-01-22 17:31:21 UTC) #1
Mike West
LGTM.
4 years, 11 months ago (2016-01-22 19:21:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1620393002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1620393002/1
4 years, 11 months ago (2016-01-25 18:34:45 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/121330) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 11 months ago (2016-01-25 18:37:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1620393002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1620393002/20001
4 years, 11 months ago (2016-01-25 23:20:24 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-26 00:37:20 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2016-01-26 00:38:18 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/45a6c6950aa8dd41d710664b7bf020b8c6da8410
Cr-Commit-Position: refs/heads/master@{#371381}

Powered by Google App Engine
This is Rietveld 408576698