Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 162033002: rAc: only run CountryComboboxModel tests on applicable platforms. (Closed)

Created:
6 years, 10 months ago by Dan Beam
Modified:
6 years, 10 months ago
Reviewers:
Nico, Evan Stade
CC:
chromium-reviews, benquan, Dane Wallinga, dyu1, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org
Visibility:
Public.

Description

rAc: only run CountryComboboxModel tests on applicable platforms. R=thakis@chromium.org BUG=341329 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251020

Patch Set 1 #

Patch Set 2 : just don't compile tests on GTK #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -15 lines) Patch
M chrome/browser/ui/autofill/country_combobox_model_unittest.cc View 1 1 chunk +4 lines, -14 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
Dan Beam
/me wonders which trybots might actually use GTK still...
6 years, 10 months ago (2014-02-12 23:23:12 UTC) #1
Dan Beam
guess thakis@ is in hiding, +estade@
6 years, 10 months ago (2014-02-12 23:50:34 UTC) #2
Evan Stade
personally i'd exclude the whole file on gtk
6 years, 10 months ago (2014-02-13 00:19:56 UTC) #3
Dan Beam
On 2014/02/13 00:19:56, Evan Stade wrote: > personally i'd exclude the whole file on gtk ...
6 years, 10 months ago (2014-02-13 00:23:14 UTC) #4
Evan Stade
lgtm
6 years, 10 months ago (2014-02-13 01:23:40 UTC) #5
Dan Beam
The CQ bit was checked by dbeam@chromium.org
6 years, 10 months ago (2014-02-13 02:17:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/162033002/60001
6 years, 10 months ago (2014-02-13 02:22:46 UTC) #7
commit-bot: I haz the power
6 years, 10 months ago (2014-02-13 15:25:53 UTC) #8
Message was sent while issue was closed.
Change committed as 251020

Powered by Google App Engine
This is Rietveld 408576698