Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 1620313004: PPC: [stubs] Introduce ToNameStub to implement %_ToName. (Closed)

Created:
4 years, 11 months ago by MTBrandyberry
Modified:
4 years, 11 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [stubs] Introduce ToNameStub to implement %_ToName. Port a0878333de4dd090f9d8987e1698a9eef9cc7219 Original commit message: We already had hand-written optimized code for %_ToName in fullcodegen, but the optimizing compilers always went to the runtime for %_ToName, which is pretty bad for many of our builtins. So this CL moves the existing native code to a ToNameStub (similar to the existing ToStringStub), and uses the ToNameStub consistently in all compilers to actually implement %_ToName. R=bmeurer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= Committed: https://crrev.com/12ac11e98faf09890d6f5baa38e8d36aea788eb4 Cr-Commit-Position: refs/heads/master@{#33476}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -20 lines) Patch
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 chunk +0 lines, -20 lines 0 comments Download
M src/ppc/code-stubs-ppc.cc View 1 chunk +31 lines, -0 lines 0 comments Download
M src/ppc/interface-descriptors-ppc.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
MTBrandyberry
4 years, 11 months ago (2016-01-22 15:44:49 UTC) #1
john.yan
lgtm
4 years, 11 months ago (2016-01-22 18:30:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1620313004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1620313004/1
4 years, 11 months ago (2016-01-22 18:31:08 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-22 18:55:15 UTC) #5
commit-bot: I haz the power
4 years, 11 months ago (2016-01-22 18:56:21 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/12ac11e98faf09890d6f5baa38e8d36aea788eb4
Cr-Commit-Position: refs/heads/master@{#33476}

Powered by Google App Engine
This is Rietveld 408576698