Issue 16203004: Fix LoadIC calling convention on ARM

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16203004: Fix LoadIC calling convention on ARM (Closed)

Created:
7 years, 6 months ago by wingo

Modified:
7 years, 6 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix LoadIC calling convention on ARM The comments in ic-arm.cc::LoadIC indicated that the receiver should be both in a register and on the stack. This isn't true in fact: the code is careful to spill the receiver if needed. This CL also fixes up a mistaken use of this convention in in VisitYield. R=mstarzinger@chromium.org BUG= Committed: http://code.google.com/p/v8/source/detail?r=15027

Patch Set 1 #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -10 lines)			Patch
	M	src/arm/full-codegen-arm.cc	View		3 chunks	+0 lines, -6 lines	0 comments	Download
	M	src/arm/ic-arm.cc	View		4 chunks	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

wingo

7 years, 6 months ago (2013-06-10 09:13:22 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r15027 (presubmit successful).

Expand Messages | Collapse Messages