gpu/command_buffer/build_gles2_cmd_buffer.py - Issue 162023002: Reduce internal Flush() in GL resource glGen/Delete APIs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/build_gles2_cmd_buffer.py

Issue 162023002: Reduce internal Flush() in GL resource glGen/Delete APIs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert lock_ pattern change in IdHandler::FreeIds. Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: gpu/command_buffer/build_gles2_cmd_buffer.py

diff --git a/gpu/command_buffer/build_gles2_cmd_buffer.py b/gpu/command_buffer/build_gles2_cmd_buffer.py

index 23dacf128fbfe07febd453c5d16bcf16587b3316..51b170748f5e40e49cc4ecac874cf17c9cfcc052 100755

--- a/gpu/command_buffer/build_gles2_cmd_buffer.py

+++ b/gpu/command_buffer/build_gles2_cmd_buffer.py

@@ -3951,7 +3951,8 @@ class GENnHandler(TypeHandler):

MakeIds(this, 0, %(args)s);

%(name)sHelper(%(args)s);

helper_->%(name)sImmediate(%(args)s);

- helper_->CommandBufferHelper::Flush();

+ if (share_group_->bind_generates_resource())

+ helper_->CommandBufferHelper::Flush();

%(log_code)s

CheckGLError();

}

« no previous file with comments | « no previous file | gpu/command_buffer/client/cmd_buffer_helper.h » ('j') | no next file with comments »