Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(781)

Issue 1620203006: set LibraryElement documentation to docs of first directive in CU (Closed)

Created:
4 years, 11 months ago by keertip
Modified:
4 years, 11 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

set LibraryElement documentation to docs of first directive in CU BUG= R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/946ae8f80702dc75fef94c5843347d7bc1802373

Patch Set 1 #

Total comments: 2

Patch Set 2 : remove unused var #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -8 lines) Patch
M pkg/analyzer/lib/src/task/dart.dart View 1 3 chunks +7 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
keertip
4 years, 11 months ago (2016-01-22 22:05:18 UTC) #2
Brian Wilkerson
LGTM https://codereview.chromium.org/1620203006/diff/1/pkg/analyzer/lib/src/task/dart.dart File pkg/analyzer/lib/src/task/dart.dart (right): https://codereview.chromium.org/1620203006/diff/1/pkg/analyzer/lib/src/task/dart.dart#newcode1498 pkg/analyzer/lib/src/task/dart.dart:1498: _setDoc(libraryElement, definingCompilationUnit.directives.first); Given that this was the only ...
4 years, 11 months ago (2016-01-22 22:44:52 UTC) #3
keertip
https://codereview.chromium.org/1620203006/diff/1/pkg/analyzer/lib/src/task/dart.dart File pkg/analyzer/lib/src/task/dart.dart (right): https://codereview.chromium.org/1620203006/diff/1/pkg/analyzer/lib/src/task/dart.dart#newcode1498 pkg/analyzer/lib/src/task/dart.dart:1498: _setDoc(libraryElement, definingCompilationUnit.directives.first); On 2016/01/22 22:44:52, Brian Wilkerson wrote: > ...
4 years, 11 months ago (2016-01-23 00:12:04 UTC) #4
keertip
4 years, 11 months ago (2016-01-23 00:13:27 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
946ae8f80702dc75fef94c5843347d7bc1802373 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698