Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 16202: Fix 4830: We navigate back after closing the Save As dialog.... (Closed)

Created:
12 years ago by Finnur
Modified:
9 years, 6 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Fix 4830: We navigate back after closing the Save As dialog. If you use Alt-Shift-T and the arrow keys to go to the Page menu and then launch the Save Page As dialog, we would navigate back after saving the page. This is because once we close the Save As dialog with Enter, focus goes to the Back button (which arguable is also wrong, see issue 5750) and it receives a KeyRelease(Enter), which causes us to navigate back right after saving the page. In Windows, pressing Enter while a button has focus clicks the button on KeyPressed, whereas we currently click the button on KeyRelease. This patch makes Chrome mimic native Windows behavior. We retain the current behavior for Space, however, which clicks on KeyReleased in both Chrome and Windows. BUG=4830 TEST=Native Chrome buttons should click buttons on KeyPress when using Enter and on KeyRelease when using Space. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=7406

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M chrome/views/base_button.cc View 2 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Finnur
12 years ago (2008-12-21 05:06:54 UTC) #1
Peter Kasting
12 years ago (2008-12-22 17:58:05 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698