Allow theming of colors for the Mac.

Allow theming of colors for the Mac.

BUG=http://crbug.com/18438
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=23023

[Avi (use Gerrit), 2009-08-07 21:32:47]

ping?

[John Grabowski, 2009-08-07 21:34:52]

erikkay out on paternity.
jrg


On Fri, Aug 7, 2009 at 2:32 PM, <avi@chromium.org> wrote:

> ping?
>
>
>
> http://codereview.chromium.org/162010
>

[Avi (use Gerrit), 2009-08-10 15:39:24]

Glen, can you give this a look?

[Glen Murphy, 2009-08-10 23:35:52]

LGTM, thanks for cleaning the color stuff up.

Feel free to submit before me, but I have a coming change to support the NNTP
that conflicts a little with this - see
http://codereview.chromium.org/165192/diff/15/1005 line 292 - I may just add the
special-casing at the top of GetColor, but if you have a better idea, I'm all
ears.

[Avi (use Gerrit), 2009-08-11 03:33:20]

Can't think of a great way to do that other than special-casing. It doesn't
matter if the Mac version of the color function doesn't pull that value
because it's not going to hit that id, right?

Avi

On Mon, Aug 10, 2009 at 7:35 PM, <glen@chromium.org> wrote:

> LGTM, thanks for cleaning the color stuff up.
>
> Feel free to submit before me, but I have a coming change to support the
> NNTP that conflicts a little with this - see
> http://codereview.chromium.org/165192/diff/15/1005 line 292 - I may just
> add the special-casing at the top of GetColor, but if you have a better
> idea, I'm all ears.
>
>
> http://codereview.chromium.org/162010
>

[Nico, 2009-09-05 21:20:20]

Zombie comment!

http://codereview.chromium.org/162010/diff/1/4
File chrome/browser/browser_theme_provider_mac.mm (right):

http://codereview.chromium.org/162010/diff/1/4#newcode82
Line 82: NSColor* color = [NSColor colorWithCalibratedRed:SkColorGetR(sk_color)
Come on guys. NSColor wants its channels in [0.0..1.0], while skia uses the
traditional 0..255.

I will fix this in my "final download item tweaks" CL, but this could've been
caught :-|