Issue 162004: Add a readline() command to d8. This reads a single line, stripping the...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 162004: Add a readline() command to d8. This reads a single line, stripping the...

Created:
11 years, 4 months ago by abdulla

Modified:
9 years, 7 months ago

Reviewers:
Christian Plesner Hansen

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Add a readline() command to d8. This reads a single line, stripping the new-line at the end. This is the other half of what is required to make the Debian Language Shootout code work correctly: http://code.google.com/p/v8/issues/detail?id=353 BUG=353

Patch Set 1 #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -3 lines)			Patch
	M	src/d8.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	src/d8.cc	View		4 chunks	+17 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Christian Plesner Hansen

What happened to the previous code review, 115747? Anyway, LGTM.

11 years, 4 months ago (2009-08-13 07:00:47 UTC) #2

Christian Plesner Hansen

Landed in http://code.google.com/p/v8/source/detail?r=2671.

11 years, 4 months ago (2009-08-13 07:08:24 UTC) #3

abdulla

11 years, 4 months ago (2009-08-13 07:31:57 UTC) #4

On 2009/08/13 07:00:47, Christian Plesner Hansen wrote:
> What happened to the previous code review, 115747?
> 
> Anyway, LGTM.

Sorry, it was the same thing that happened to the last, I lost my workspace.

Expand Messages | Collapse Messages