Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Issue 1620023002: Revert of Remove catapult_base from telemetry. (Closed)

Created:
4 years, 11 months ago by aiolos (Not reviewing)
Modified:
4 years, 11 months ago
Reviewers:
eakuefner
CC:
chromium-reviews, telemetry-reviews_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@perf_cb_move
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove catapult_base from telemetry. (patchset #1 id:1 of https://codereview.chromium.org/1599413006/ ) Reason for revert: Breaks gpu_tests. Original issue's description: > Remove catapult_base from telemetry. > > This is dependent on https://codereview.chromium.org/1568103002/ and > https://codereview.chromium.org/1565403005/ landing. > > BUG=565604 > > Committed: https://crrev.com/a32c24edfa6d09499ba873ba616b35a1de8912e5 > Cr-Commit-Position: refs/heads/master@{#370630} TBR=eakuefner@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=565604

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2728 lines, --1 lines) Patch
A tools/telemetry/catapult_base/__init__.py View 1 chunk +23 lines, -0 lines 0 comments Download
A tools/telemetry/catapult_base/bin/run_tests View 1 chunk +38 lines, -0 lines 0 comments Download
A tools/telemetry/catapult_base/cloud_storage.py View 1 chunk +348 lines, -0 lines 0 comments Download
A tools/telemetry/catapult_base/dependency_manager/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
A tools/telemetry/catapult_base/dependency_manager/__init__.py View 1 chunk +14 lines, -0 lines 0 comments Download
A tools/telemetry/catapult_base/dependency_manager/archive_info.py View 1 chunk +69 lines, -0 lines 0 comments Download
A tools/telemetry/catapult_base/dependency_manager/base_config.py View 1 chunk +380 lines, -0 lines 0 comments Download
A tools/telemetry/catapult_base/dependency_manager/cloud_storage_info.py View 1 chunk +110 lines, -0 lines 0 comments Download
A tools/telemetry/catapult_base/dependency_manager/dependency_info.py View 1 chunk +123 lines, -0 lines 0 comments Download
A tools/telemetry/catapult_base/dependency_manager/dependency_manager.py View 1 chunk +172 lines, -0 lines 0 comments Download
A tools/telemetry/catapult_base/dependency_manager/dependency_manager_util.py View 1 chunk +95 lines, -0 lines 0 comments Download
A tools/telemetry/catapult_base/dependency_manager/exceptions.py View 1 chunk +48 lines, -0 lines 0 comments Download
A tools/telemetry/catapult_base/dependency_manager/local_path_info.py View 1 chunk +40 lines, -0 lines 0 comments Download
A tools/telemetry/catapult_base/dependency_manager/uploader.py View 1 chunk +106 lines, -0 lines 0 comments Download
A tools/telemetry/catapult_base/refactor/__init__.py View 1 chunk +28 lines, -0 lines 0 comments Download
A tools/telemetry/catapult_base/refactor/annotated_symbol/__init__.py View 1 chunk +71 lines, -0 lines 0 comments Download
A tools/telemetry/catapult_base/refactor/annotated_symbol/base_symbol.py View 1 chunk +36 lines, -0 lines 0 comments Download
A tools/telemetry/catapult_base/refactor/annotated_symbol/class_definition.py View 1 chunk +48 lines, -0 lines 0 comments Download
A tools/telemetry/catapult_base/refactor/annotated_symbol/function_definition.py View 1 chunk +48 lines, -0 lines 0 comments Download
A tools/telemetry/catapult_base/refactor/annotated_symbol/import_statement.py View 1 chunk +322 lines, -0 lines 0 comments Download
A tools/telemetry/catapult_base/refactor/annotated_symbol/reference.py View 1 chunk +75 lines, -0 lines 0 comments Download
A tools/telemetry/catapult_base/refactor/module.py View 1 chunk +38 lines, -0 lines 0 comments Download
A tools/telemetry/catapult_base/refactor/offset_token.py View 1 chunk +113 lines, -0 lines 0 comments Download
A tools/telemetry/catapult_base/refactor/snippet.py View 1 chunk +242 lines, -0 lines 0 comments Download
A tools/telemetry/catapult_base/refactor_util/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A tools/telemetry/catapult_base/refactor_util/move.py View 1 chunk +115 lines, -0 lines 0 comments Download
A tools/telemetry/catapult_base/test_data/foo.txt View 1 chunk +1 line, -0 lines 0 comments Download
A tools/telemetry/catapult_base/util.py View 1 chunk +25 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
aiolos (Not reviewing)
Created Revert of Remove catapult_base from telemetry.
4 years, 11 months ago (2016-01-21 22:50:21 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1620023002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1620023002/1
4 years, 11 months ago (2016-01-21 22:51:19 UTC) #2
aiolos (Not reviewing)
4 years, 11 months ago (2016-01-21 23:03:00 UTC) #5
Nevermind. Fixing presubmit in https://codereview.chromium.org/1611053003/
instead.

Powered by Google App Engine
This is Rietveld 408576698