Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1619963002: Add UseCounter for weird body+viewport scrolling (Closed)

Created:
4 years, 11 months ago by Rick Byers
Modified:
4 years, 11 months ago
Reviewers:
skobes
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis, philipj_slow
Base URL:
https://chromium.googlesource.com/chromium/src.git@mousewheel-usecounter
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add UseCounter for weird body+viewport scrolling BUG=580570 Committed: https://crrev.com/da7409752ec17470f731d23b8e91b899b30fc6c7 Cr-Commit-Position: refs/heads/master@{#370990}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M third_party/WebKit/Source/core/dom/Document.cpp View 1 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Rick Byers
skobes@ PTAL at this tiny CL It's looking like I may not be able to ...
4 years, 11 months ago (2016-01-21 21:56:12 UTC) #2
skobes
lgtm I haven't studied the spec in this regard but I can't think of a ...
4 years, 11 months ago (2016-01-22 00:03:24 UTC) #3
Rick Byers
On 2016/01/22 00:03:24, skobes wrote: > lgtm > > I haven't studied the spec in ...
4 years, 11 months ago (2016-01-22 16:24:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1619963002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1619963002/20001
4 years, 11 months ago (2016-01-22 16:26:09 UTC) #8
skobes
On 2016/01/22 16:24:12, Rick Byers wrote: > On 2016/01/22 00:03:24, skobes wrote: > > lgtm ...
4 years, 11 months ago (2016-01-22 17:41:20 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-22 17:54:57 UTC) #11
commit-bot: I haz the power
4 years, 11 months ago (2016-01-22 17:56:43 UTC) #13
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/da7409752ec17470f731d23b8e91b899b30fc6c7
Cr-Commit-Position: refs/heads/master@{#370990}

Powered by Google App Engine
This is Rietveld 408576698