Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Unified Diff: components/cronet/android/api/src/org/chromium/net/JavaUrlRequest.java

Issue 1619923004: Fix doing network operations on wrong executor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix doing network operations on wrong executor Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/cronet/android/test/javatests/src/org/chromium/net/TestUrlRequestCallback.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/cronet/android/api/src/org/chromium/net/JavaUrlRequest.java
diff --git a/components/cronet/android/api/src/org/chromium/net/JavaUrlRequest.java b/components/cronet/android/api/src/org/chromium/net/JavaUrlRequest.java
index b4dbd875a9d6f429c6b7e46f24f5725296cd70cc..e48fa899034b9a5913c506abf076e08675d3af5b 100644
--- a/components/cronet/android/api/src/org/chromium/net/JavaUrlRequest.java
+++ b/components/cronet/android/api/src/org/chromium/net/JavaUrlRequest.java
@@ -326,7 +326,7 @@ final class JavaUrlRequest implements UrlRequest {
}
void startRead() {
- mUserExecutor.execute(uploadErrorSetting(new CheckedRunnable() {
+ mExecutor.execute(errorSetting(State.STARTED, new CheckedRunnable() {
@Override
public void run() throws Exception {
if (mOutputChannel == null) {
@@ -336,7 +336,12 @@ final class JavaUrlRequest implements UrlRequest {
mOutputChannel = Channels.newChannel(mUrlConnection.getOutputStream());
}
mSinkState.set(SinkState.AWAITING_READ_RESULT);
- mUploadProvider.read(OutputStreamDataSink.this, mBuffer);
+ mUserExecutor.execute(uploadErrorSetting(new CheckedRunnable() {
+ @Override
+ public void run() throws Exception {
+ mUploadProvider.read(OutputStreamDataSink.this, mBuffer);
+ }
+ }));
}
}));
}
« no previous file with comments | « no previous file | components/cronet/android/test/javatests/src/org/chromium/net/TestUrlRequestCallback.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698