Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1619923004: Fix doing network operations on wrong executor (Closed)

Created:
4 years, 11 months ago by Charles
Modified:
4 years, 11 months ago
Reviewers:
pauljensen
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix doing network operations on wrong executor BUG=580632 Committed: https://crrev.com/4e94624be1e68b4e40db44da883dcf28c130d71d Cr-Commit-Position: refs/heads/master@{#371842}

Patch Set 1 #

Patch Set 2 : Avoid performing network operations on the user's executor. #

Patch Set 3 : Fix doing network operations on wrong executor #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -4 lines) Patch
M components/cronet/android/api/src/org/chromium/net/JavaUrlRequest.java View 2 chunks +7 lines, -2 lines 0 comments Download
M components/cronet/android/test/javatests/src/org/chromium/net/TestUrlRequestCallback.java View 2 chunks +18 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Charles
PTAL
4 years, 11 months ago (2016-01-27 17:38:39 UTC) #3
pauljensen
lgtm...I should have caught this in review :(
4 years, 11 months ago (2016-01-27 18:58:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1619923004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1619923004/40001
4 years, 11 months ago (2016-01-27 19:09:59 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 11 months ago (2016-01-27 19:37:50 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-27 19:39:07 UTC) #10
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/4e94624be1e68b4e40db44da883dcf28c130d71d
Cr-Commit-Position: refs/heads/master@{#371842}

Powered by Google App Engine
This is Rietveld 408576698