Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 1619913005: Rename TypeRef to EntityRef. (Closed)

Created:
4 years, 11 months ago by Paul Berry
Modified:
4 years, 11 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Rename TypeRef to EntityRef. Now that we're storing constants in the summary, the we can have legitimate references to things other than types. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/dd209aa19cc549763665539b8f44dc9b2dc69471

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+457 lines, -452 lines) Patch
M pkg/analyzer/lib/src/summary/format.dart View 49 chunks +300 lines, -297 lines 0 comments Download
M pkg/analyzer/lib/src/summary/resynthesize.dart View 4 chunks +7 lines, -7 lines 0 comments Download
M pkg/analyzer/lib/src/summary/summarize_ast.dart View 6 chunks +9 lines, -9 lines 0 comments Download
M pkg/analyzer/lib/src/summary/summarize_const_expr.dart View 2 chunks +5 lines, -5 lines 0 comments Download
M pkg/analyzer/lib/src/summary/summarize_elements.dart View 5 chunks +12 lines, -12 lines 0 comments Download
M pkg/analyzer/test/src/summary/summary_common.dart View 45 chunks +59 lines, -59 lines 2 comments Download
M pkg/analyzer/tool/summary/idl.dart View 10 chunks +65 lines, -63 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Paul Berry
4 years, 11 months ago (2016-01-21 22:34:17 UTC) #2
scheglov
LGTM https://codereview.chromium.org/1619913005/diff/1/pkg/analyzer/test/src/summary/summary_common.dart File pkg/analyzer/test/src/summary/summary_common.dart (right): https://codereview.chromium.org/1619913005/diff/1/pkg/analyzer/test/src/summary/summary_common.dart#newcode115 pkg/analyzer/test/src/summary/summary_common.dart:115: typedef void _TypeRefValidator(EntityRef unlinkedTypeRef); Rename the type and ...
4 years, 11 months ago (2016-01-21 22:40:42 UTC) #3
Paul Berry
https://codereview.chromium.org/1619913005/diff/1/pkg/analyzer/test/src/summary/summary_common.dart File pkg/analyzer/test/src/summary/summary_common.dart (right): https://codereview.chromium.org/1619913005/diff/1/pkg/analyzer/test/src/summary/summary_common.dart#newcode115 pkg/analyzer/test/src/summary/summary_common.dart:115: typedef void _TypeRefValidator(EntityRef unlinkedTypeRef); On 2016/01/21 22:40:42, scheglov wrote: ...
4 years, 11 months ago (2016-01-21 22:53:48 UTC) #4
Paul Berry
4 years, 11 months ago (2016-01-21 22:54:03 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
dd209aa19cc549763665539b8f44dc9b2dc69471 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698