Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Issue 1619913002: [Android] Set enable_remoting=true by default (Closed)

Created:
4 years, 11 months ago by pkotwicz
Modified:
4 years, 11 months ago
Reviewers:
Lambros, Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Set enable_remoting=true by default We set enable_remoting=true in the command line on the official builders. Set enable_remoting=true as the default on Chromium as well. BUG=544298 Committed: https://crrev.com/9fdef29316fae0cf8ba6c7258b434432d40eb175 Cr-Commit-Position: refs/heads/master@{#371604}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/config/features.gni View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (8 generated)
pkotwicz
lambroslambrou@ can you please take a look?
4 years, 11 months ago (2016-01-26 16:04:25 UTC) #3
Lambros
lgtm
4 years, 11 months ago (2016-01-26 18:00:40 UTC) #4
pkotwicz
dpranke@ for OWNERS
4 years, 11 months ago (2016-01-26 18:02:34 UTC) #6
Dirk Pranke
lgtm
4 years, 11 months ago (2016-01-26 18:20:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1619913002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1619913002/1
4 years, 11 months ago (2016-01-26 20:12:51 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_chromium_gn_compile_rel/builds/13135)
4 years, 11 months ago (2016-01-26 20:37:58 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1619913002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1619913002/1
4 years, 11 months ago (2016-01-26 21:15:56 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-26 21:38:40 UTC) #15
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/9fdef29316fae0cf8ba6c7258b434432d40eb175 Cr-Commit-Position: refs/heads/master@{#371604}
4 years, 11 months ago (2016-01-26 21:39:50 UTC) #17
pkotwicz
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1634353003/ by pkotwicz@chromium.org. ...
4 years, 11 months ago (2016-01-27 01:49:42 UTC) #18
Lambros
4 years, 11 months ago (2016-01-27 01:58:26 UTC) #19
Message was sent while issue was closed.
On 2016/01/27 01:49:42, pkotwicz wrote:
> A revert of this CL (patchset #1 id:1) has been created in
> https://codereview.chromium.org/1634353003/ by mailto:pkotwicz@chromium.org.
> 
> The reason for reverting is: This CL broke some of the internal builders which
> are building "all".
> 
> remoting_cardboard_extract_native_lib should be behind an target_arch=="arm"
if
> statement.

I see. In GYP (remoting/remoting_android.gypi), the target is defined but it's
only depended upon by remoting_apk if target_arch == "arm".

I guess the target *itself* needs to be behind the same conditional?

Powered by Google App Engine
This is Rietveld 408576698