|
|
Description[Android] Set enable_remoting=true by default
We set enable_remoting=true in the command line on the official builders. Set
enable_remoting=true as the default on Chromium as well.
BUG=544298
Committed: https://crrev.com/9fdef29316fae0cf8ba6c7258b434432d40eb175
Cr-Commit-Position: refs/heads/master@{#371604}
Patch Set 1 #
Messages
Total messages: 19 (8 generated)
Description was changed from ========== [Android] Set enable_remoting=true by default We set enable_remoting=true in the command line on the official builders. Do the same in chromium. BUG=544298 ========== to ========== [Android] Set enable_remoting=true by default We set enable_remoting=true in the command line on the official builders. Set enable_remoting=true as the default on Chromium as well. BUG=544298 ==========
pkotwicz@chromium.org changed reviewers: + lambroslambrou@chromium.org
lambroslambrou@ can you please take a look?
lgtm
pkotwicz@chromium.org changed reviewers: + dpranke@chromium.org
dpranke@ for OWNERS
lgtm
The CQ bit was checked by pkotwicz@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1619913002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1619913002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
The CQ bit was checked by pkotwicz@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1619913002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1619913002/1
Message was sent while issue was closed.
Description was changed from ========== [Android] Set enable_remoting=true by default We set enable_remoting=true in the command line on the official builders. Set enable_remoting=true as the default on Chromium as well. BUG=544298 ========== to ========== [Android] Set enable_remoting=true by default We set enable_remoting=true in the command line on the official builders. Set enable_remoting=true as the default on Chromium as well. BUG=544298 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== [Android] Set enable_remoting=true by default We set enable_remoting=true in the command line on the official builders. Set enable_remoting=true as the default on Chromium as well. BUG=544298 ========== to ========== [Android] Set enable_remoting=true by default We set enable_remoting=true in the command line on the official builders. Set enable_remoting=true as the default on Chromium as well. BUG=544298 Committed: https://crrev.com/9fdef29316fae0cf8ba6c7258b434432d40eb175 Cr-Commit-Position: refs/heads/master@{#371604} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/9fdef29316fae0cf8ba6c7258b434432d40eb175 Cr-Commit-Position: refs/heads/master@{#371604}
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1634353003/ by pkotwicz@chromium.org. The reason for reverting is: This CL broke some of the internal builders which are building "all". remoting_cardboard_extract_native_lib should be behind an target_arch=="arm" if statement.
Message was sent while issue was closed.
On 2016/01/27 01:49:42, pkotwicz wrote: > A revert of this CL (patchset #1 id:1) has been created in > https://codereview.chromium.org/1634353003/ by mailto:pkotwicz@chromium.org. > > The reason for reverting is: This CL broke some of the internal builders which > are building "all". > > remoting_cardboard_extract_native_lib should be behind an target_arch=="arm" if > statement. I see. In GYP (remoting/remoting_android.gypi), the target is defined but it's only depended upon by remoting_apk if target_arch == "arm". I guess the target *itself* needs to be behind the same conditional? |