Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 1619703003: Pass values in the right flow thread's coordinate space. (Closed)

Created:
4 years, 11 months ago by mstensho (USE GERRIT)
Modified:
4 years, 11 months ago
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, mstensho (USE GERRIT), pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Pass values in the right flow thread's coordinate space. We were talking to our enclosing flow thread, but using coordinates in our own flow thread coordinate space. This caused both miserable rendering and assertion failures, since we'd fail to realize that there'd be rows further ahead with enough space for the content we were trying to fit. BUG=552615 R=leviw@chromium.org Committed: https://crrev.com/c7f2728c37d3ce0ac93645f50782006f5c9bce1d Cr-Commit-Position: refs/heads/master@{#370891}

Patch Set 1 #

Patch Set 2 : Moar line-height. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
A third_party/WebKit/LayoutTests/fast/multicol/line-too-tall-for-second-outer-row.html View 1 chunk +9 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/multicol/line-too-tall-for-second-outer-row-expected.html View 1 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
mstensho (USE GERRIT)
4 years, 11 months ago (2016-01-21 18:31:56 UTC) #1
leviw_travelin_and_unemployed
lgtm D'oh :-/
4 years, 11 months ago (2016-01-22 03:18:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1619703003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1619703003/20001
4 years, 11 months ago (2016-01-22 03:20:33 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-22 03:26:11 UTC) #5
commit-bot: I haz the power
4 years, 11 months ago (2016-01-22 03:27:05 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c7f2728c37d3ce0ac93645f50782006f5c9bce1d
Cr-Commit-Position: refs/heads/master@{#370891}

Powered by Google App Engine
This is Rietveld 408576698