third_party/WebKit/Source/modules/serviceworkers/WaitUntilObserver.cpp - Issue 1619703002: Implement notificationclose event

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/serviceworkers/WaitUntilObserver.cpp

Issue 1619703002: Implement notificationclose event (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Removed some logging statements Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/service_worker/service_worker_version.cc ('K') | « third_party/WebKit/Source/modules/serviceworkers/WaitUntilObserver.h ('k') | third_party/WebKit/Source/web/ServiceWorkerGlobalScopeClientImpl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/serviceworkers/WaitUntilObserver.cpp

diff --git a/third_party/WebKit/Source/modules/serviceworkers/WaitUntilObserver.cpp b/third_party/WebKit/Source/modules/serviceworkers/WaitUntilObserver.cpp

index 1535e6683c411fcf8eb5dc6b043ba45148b90a8a..7538c9d01bfbd5ae5426a42559e04cd57edfa2d7 100644

--- a/third_party/WebKit/Source/modules/serviceworkers/WaitUntilObserver.cpp

+++ b/third_party/WebKit/Source/modules/serviceworkers/WaitUntilObserver.cpp

@@ -174,6 +174,10 @@ void WaitUntilObserver::decrementPendingActivity()

m_consumeWindowInteractionTimer.stop();

Nina 2016/01/21 13:55:36 I can't figure out what this does. Mind giving me

consumeWindowInteraction(nullptr);

break;

+ case NotificationClose:

+ // TODO(nsatragno): figure out what consumeWindowInteraction does.

+ client->didHandleNotificationCloseEvent(m_eventID, result);

+ break;

case Push:

client->didHandlePushEvent(m_eventID, result);

break;