third_party/WebKit/Source/modules/notifications/Notification.h - Issue 1619703002: Implement notificationclose event

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/notifications/Notification.h

Issue 1619703002: Implement notificationclose event (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed nits Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/notifications/Notification.h

diff --git a/third_party/WebKit/Source/modules/notifications/Notification.h b/third_party/WebKit/Source/modules/notifications/Notification.h

index 23fe5b817e771fdc57a015e78ada06f944eab41b..7e0f7e30af5729046b1712f5dbeee4ce964004b7 100644

--- a/third_party/WebKit/Source/modules/notifications/Notification.h

+++ b/third_party/WebKit/Source/modules/notifications/Notification.h

@@ -66,8 +66,9 @@ public:

// the notification to be displayed to the user when the developer-provided data is valid.

static Notification* create(ExecutionContext*, const String& title, const NotificationOptions&, ExceptionState&);

- // Used for embedder-created Notification objects. Will initialize the Notification's state as showing.

- static Notification* create(ExecutionContext*, int64_t persistentId, const WebNotificationData&);

+ // Used for embedder-created Notification objects. If |showing| is true, will initialize the

+ // Notification's state as showing, or as closed otherwise.

+ static Notification* create(ExecutionContext*, int64_t persistentId, const WebNotificationData&, bool showing);

~Notification() override;