Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1812)

Unified Diff: content/public/browser/notification_event_dispatcher.h

Issue 1619703002: Implement notificationclose event (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed nits Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/notification_event_dispatcher.h
diff --git a/content/public/browser/notification_event_dispatcher.h b/content/public/browser/notification_event_dispatcher.h
index bb3df945e2364e89cf3eb712087fe24ffe35b635..9cc43d4017c8a5163b203d7439e73498529fe4aa 100644
--- a/content/public/browser/notification_event_dispatcher.h
+++ b/content/public/browser/notification_event_dispatcher.h
@@ -27,7 +27,7 @@ class CONTENT_EXPORT NotificationEventDispatcher {
public:
static NotificationEventDispatcher* GetInstance();
- using NotificationClickDispatchCompleteCallback =
+ using NotificationDispatchCompleteCallback =
base::Callback<void(PersistentNotificationStatus)>;
// Dispatches the "notificationclick" event on the Service Worker associated
@@ -38,7 +38,19 @@ class CONTENT_EXPORT NotificationEventDispatcher {
int64_t persistent_notification_id,
const GURL& origin,
int action_index,
- const NotificationClickDispatchCompleteCallback&
+ const NotificationDispatchCompleteCallback&
+ dispatch_complete_callback) = 0;
+
+ // Dispatches the "notificationclose" event on the Service Worker associated
+ // with |persistent_notification_id| belonging to |origin|. The
+ // |dispatch_complete_callback| will be invoked when it's known whether the
+ // event successfully executed.
+ virtual void DispatchNotificationCloseEvent(
+ BrowserContext* browser_context,
+ int64_t persistent_notification_id,
+ const GURL& origin,
+ bool by_user,
+ const NotificationDispatchCompleteCallback&
dispatch_complete_callback) = 0;
protected:

Powered by Google App Engine
This is Rietveld 408576698