Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1227)

Unified Diff: content/browser/service_worker/service_worker_metrics.cc

Issue 1619703002: Implement notificationclose event (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed nits Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_metrics.cc
diff --git a/content/browser/service_worker/service_worker_metrics.cc b/content/browser/service_worker/service_worker_metrics.cc
index c1d3699ddaf3580577fadf5723d339c8b38eb4f3..6b74eaf09254c9514960b78e0f864f525f00922b 100644
--- a/content/browser/service_worker/service_worker_metrics.cc
+++ b/content/browser/service_worker/service_worker_metrics.cc
@@ -58,6 +58,8 @@ const char* ServiceWorkerMetrics::EventTypeToString(EventType event_type) {
return "Sync";
case EventType::NOTIFICATION_CLICK:
return "Notification Click";
+ case EventType::NOTIFICATION_CLOSE:
+ return "Notification Close";
case EventType::PUSH:
return "Push";
case EventType::GEOFENCING:
@@ -226,6 +228,10 @@ void ServiceWorkerMetrics::RecordEventDuration(EventType event,
UMA_HISTOGRAM_MEDIUM_TIMES("ServiceWorker.NotificationClickEvent.Time",
time);
break;
+ case EventType::NOTIFICATION_CLOSE:
+ UMA_HISTOGRAM_MEDIUM_TIMES("ServiceWorker.NotificationCloseEvent.Time",
+ time);
+ break;
case EventType::PUSH:
UMA_HISTOGRAM_MEDIUM_TIMES("ServiceWorker.PushEvent.Time", time);
break;
« no previous file with comments | « content/browser/service_worker/service_worker_metrics.h ('k') | content/common/service_worker/service_worker_messages.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698