third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextProxy.h - Issue 1619703002: Implement notificationclose event

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextProxy.h

Issue 1619703002: Implement notificationclose event (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed test expectations and compile error Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/public/browser/notification_event_dispatcher.h ('K') | « third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h ('k') | tools/metrics/histograms/histograms.xml » ('j') | tools/metrics/histograms/histograms.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextProxy.h

diff --git a/third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextProxy.h b/third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextProxy.h

index df94ff5e791c9db7ddfa8c4f3865b6c7b25a25cc..09f70f97d4794a8be1caca392a895b7cad8e9b5e 100644

--- a/third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextProxy.h

+++ b/third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextProxy.h

@@ -65,6 +65,8 @@ public:

virtual void dispatchNotificationClickEvent(int eventID, int64_t notificationID, const WebNotificationData&, int actionIndex) = 0;

+ virtual void dispatchNotificationCloseEvent(int eventID, int64_t notificationID, const WebNotificationData&) = 0;

virtual void dispatchPushEvent(int eventID, const WebString& data) = 0;

virtual void dispatchCrossOriginMessageEvent(const WebCrossOriginServiceWorkerClient&, const WebString& message, const WebMessagePortChannelArray&) = 0;