third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h - Issue 1619703002: Implement notificationclose event

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h

Issue 1619703002: Implement notificationclose event (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed test expectations and compile error Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/public/browser/notification_event_dispatcher.h ('K') | « third_party/WebKit/Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp ('k') | third_party/WebKit/Source/modules/serviceworkers/WaitUntilObserver.h » ('j') | tools/metrics/histograms/histograms.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h

diff --git a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h

index 5611231443cedc25b8c7f195f9fb383120d62967..eba332aec0e2662d8c51a8ec7fe1ca9b550e19d0 100644

--- a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h

+++ b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h

@@ -74,6 +74,7 @@ public:

virtual void didHandleFetchEvent(int fetchEventID, const WebServiceWorkerResponse&) = 0;

virtual void didHandleInstallEvent(int installEventID, WebServiceWorkerEventResult) = 0;

virtual void didHandleNotificationClickEvent(int eventID, WebServiceWorkerEventResult) = 0;

+ virtual void didHandleNotificationCloseEvent(int eventID, WebServiceWorkerEventResult) = 0;

virtual void didHandlePushEvent(int pushEventID, WebServiceWorkerEventResult) = 0;

virtual void didHandleSyncEvent(int syncEventID, WebServiceWorkerEventResult) = 0;

virtual void postMessageToClient(const WebString& clientUUID, const WebString& message, PassOwnPtr<WebMessagePortChannelArray>) = 0;